From eef78144989c84a61e973ae68e47092239ff607b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Joshua=20R=C3=BCsweg?= <josh@bastelstu.be>
Date: Fri, 31 Aug 2018 11:37:15 +0200
Subject: [PATCH] Add permission to edit notification preset See #2598

---
 com.woltlab.wcf/acpMenu.xml                                | 2 +-
 com.woltlab.wcf/userGroupOption.xml                        | 7 +++++++
 .../lib/acp/form/NotificationPresetSettingsForm.class.php  | 2 +-
 wcfsetup/install/lang/de.xml                               | 1 +
 wcfsetup/install/lang/en.xml                               | 1 +
 5 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/com.woltlab.wcf/acpMenu.xml b/com.woltlab.wcf/acpMenu.xml
index 18a6eadd99..09d83b3dec 100644
--- a/com.woltlab.wcf/acpMenu.xml
+++ b/com.woltlab.wcf/acpMenu.xml
@@ -74,7 +74,7 @@
 			<acpmenuitem name="wcf.acp.menu.link.notificationPresetSettings">
 				<parent>wcf.acp.menu.link.other</parent>
 				<controller>wcf\acp\form\NotificationPresetSettingsForm</controller>
-				<permissions>admin.user.canEditUser</permissions>
+				<permissions>admin.user.canManageNotificationSettings</permissions>
 			</acpmenuitem>
 		
 			<acpmenuitem name="wcf.acp.menu.link.contact.settings">
diff --git a/com.woltlab.wcf/userGroupOption.xml b/com.woltlab.wcf/userGroupOption.xml
index 010e457f0e..2e944721dd 100644
--- a/com.woltlab.wcf/userGroupOption.xml
+++ b/com.woltlab.wcf/userGroupOption.xml
@@ -303,6 +303,13 @@
 				<admindefaultvalue>1</admindefaultvalue>
 				<usersonly>1</usersonly>
 			</option>
+			<option name="admin.user.canManageNotificationSettings">
+				<categoryname>admin.user.user</categoryname>
+				<optiontype>boolean</optiontype>
+				<defaultvalue>0</defaultvalue>
+				<admindefaultvalue>1</admindefaultvalue>
+				<usersonly>1</usersonly>
+			</option>
 			
 			<option name="admin.user.canAddGroup">
 				<categoryname>admin.user.group</categoryname>
diff --git a/wcfsetup/install/files/lib/acp/form/NotificationPresetSettingsForm.class.php b/wcfsetup/install/files/lib/acp/form/NotificationPresetSettingsForm.class.php
index 9d0a64df37..c8b72f5968 100644
--- a/wcfsetup/install/files/lib/acp/form/NotificationPresetSettingsForm.class.php
+++ b/wcfsetup/install/files/lib/acp/form/NotificationPresetSettingsForm.class.php
@@ -27,7 +27,7 @@ class NotificationPresetSettingsForm extends AbstractForm {
 	/**
 	 * @inheritDoc
 	 */
-	public $neededPermissions = ['admin.user.canEditUser'];
+	public $neededPermissions = ['admin.user.canManageNotificationSettings'];
 	
 	/**
 	 * list of notification events
diff --git a/wcfsetup/install/lang/de.xml b/wcfsetup/install/lang/de.xml
index 95458d5276..28219fa4a5 100644
--- a/wcfsetup/install/lang/de.xml
+++ b/wcfsetup/install/lang/de.xml
@@ -508,6 +508,7 @@
 		<item name="wcf.acp.group.option.admin.user.canEditPassword"><![CDATA[Kann Kennwörter bearbeiten]]></item>
 		<item name="wcf.acp.group.option.admin.user.canEditUser"><![CDATA[Kann Benutzer bearbeiten]]></item>
 		<item name="wcf.acp.group.option.admin.user.canMailUser"><![CDATA[Kann E-Mails an Benutzer senden]]></item>
+		<item name="wcf.acp.group.option.admin.user.canManageNotificationSettings"><![CDATA[Kann Vorgabewerte für Benachrichtigungen bearbeiten]]></item>
 		<item name="wcf.acp.group.option.admin.user.canSearchUser"><![CDATA[Kann Benutzer suchen]]></item>
 		<item name="wcf.acp.group.option.category.admin"><![CDATA[Administrative Rechte]]></item>
 		<item name="wcf.acp.group.option.category.admin.customization"><![CDATA[Anpassung]]></item>
diff --git a/wcfsetup/install/lang/en.xml b/wcfsetup/install/lang/en.xml
index 3481c4c6ab..2803504d52 100644
--- a/wcfsetup/install/lang/en.xml
+++ b/wcfsetup/install/lang/en.xml
@@ -490,6 +490,7 @@
 		<item name="wcf.acp.group.option.admin.user.canEditPassword"><![CDATA[Can edit user passwords]]></item>
 		<item name="wcf.acp.group.option.admin.user.canEditUser"><![CDATA[Can edit users]]></item>
 		<item name="wcf.acp.group.option.admin.user.canMailUser"><![CDATA[Can send emails to users]]></item>
+		<item name="wcf.acp.group.option.admin.user.canManageNotificationSettings"><![CDATA[Can edit default notification settings]]></item>
 		<item name="wcf.acp.group.option.admin.user.canSearchUser"><![CDATA[Can search users]]></item>
 		<item name="wcf.acp.group.option.category.admin"><![CDATA[Administrator Permissions]]></item>
 		<item name="wcf.acp.group.option.category.admin.configuration"><![CDATA[Configuration]]></item>
-- 
2.20.1