From eeb6a6ff597ee47a6ecc652dab769c3137fd1483 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Wed, 11 Nov 2015 10:07:05 +0100 Subject: [PATCH] greybus: interface: fix potential use-after-free at remove Fix resources (accessible through sysfs) being released before interface is deregistered. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c index 275a8c7df8e1..e496b1646aa5 100644 --- a/drivers/staging/greybus/interface.c +++ b/drivers/staging/greybus/interface.c @@ -60,6 +60,9 @@ static void gb_interface_release(struct device *dev) { struct gb_interface *intf = to_gb_interface(dev); + kfree(intf->product_string); + kfree(intf->vendor_string); + kfree(intf); } @@ -191,9 +194,6 @@ void gb_interface_remove(struct gb_interface *intf) list_for_each_entry_safe(bundle, next, &intf->bundles, links) gb_bundle_destroy(bundle); - kfree(intf->product_string); - kfree(intf->vendor_string); - module = intf->module; device_unregister(&intf->dev); put_device(&module->dev); -- 2.20.1