From e7de794ab5d493997ea4b195c25fd176df3a2a36 Mon Sep 17 00:00:00 2001
From: Alexander Ebert <ebert@woltlab.com>
Date: Thu, 13 Jul 2017 14:21:04 +0200
Subject: [PATCH] Minor code style fixes

---
 .../devtools/project/DevtoolsProject.class.php     |  2 +-
 .../PackageInstallationPluginAction.class.php      | 14 ++++++++++++--
 .../devtools/package/DevtoolsInstaller.class.php   |  2 +-
 .../pip/DevtoolsPackageInstallationQueue.class.php |  2 +-
 .../lib/system/devtools/pip/DevtoolsPip.class.php  |  4 +---
 5 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/wcfsetup/install/files/lib/data/devtools/project/DevtoolsProject.class.php b/wcfsetup/install/files/lib/data/devtools/project/DevtoolsProject.class.php
index c8f716e91c..6d036c39ba 100644
--- a/wcfsetup/install/files/lib/data/devtools/project/DevtoolsProject.class.php
+++ b/wcfsetup/install/files/lib/data/devtools/project/DevtoolsProject.class.php
@@ -1,9 +1,9 @@
 <?php
 namespace wcf\data\devtools\project;
-use wcf\data\DatabaseObject;
 use wcf\data\package\installation\plugin\PackageInstallationPluginList;
 use wcf\data\package\Package;
 use wcf\data\package\PackageCache;
+use wcf\data\DatabaseObject;
 use wcf\system\devtools\package\DevtoolsPackageArchive;
 use wcf\system\devtools\pip\DevtoolsPip;
 use wcf\system\package\validation\PackageValidationException;
diff --git a/wcfsetup/install/files/lib/data/package/installation/plugin/PackageInstallationPluginAction.class.php b/wcfsetup/install/files/lib/data/package/installation/plugin/PackageInstallationPluginAction.class.php
index de704dcb5d..7da39513a3 100644
--- a/wcfsetup/install/files/lib/data/package/installation/plugin/PackageInstallationPluginAction.class.php
+++ b/wcfsetup/install/files/lib/data/package/installation/plugin/PackageInstallationPluginAction.class.php
@@ -1,7 +1,7 @@
 <?php
 namespace wcf\data\package\installation\plugin;
-use wcf\data\AbstractDatabaseObjectAction;
 use wcf\data\devtools\project\DevtoolsProject;
+use wcf\data\AbstractDatabaseObjectAction;
 use wcf\system\cache\CacheHandler;
 use wcf\system\devtools\pip\DevtoolsPackageInstallationDispatcher;
 use wcf\system\devtools\pip\DevtoolsPip;
@@ -51,6 +51,12 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
 	 */
 	public $project;
 	
+	/**
+	 * Validates parameters to invoke a single PIP.
+	 * 
+	 * @throws      PermissionDeniedException
+	 * @throws      UserInputException
+	 */
 	public function validateInvoke() {
 		if (!ENABLE_DEVELOPER_TOOLS || !WCF::getSession()->getPermission('admin.configuration.package.canInstallPackage')) {
 			throw new PermissionDeniedException();
@@ -77,6 +83,11 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
 		}
 	}
 	
+	/**
+	 * Invokes a single PIP and returns the time needed to process it.
+	 * 
+	 * @return      string[]
+	 */
 	public function invoke() {
 		$dispatcher = new DevtoolsPackageInstallationDispatcher($this->project);
 		/** @var IIdempotentPackageInstallationPlugin $pip */
@@ -104,7 +115,6 @@ class PackageInstallationPluginAction extends AbstractDatabaseObjectAction {
 		
 		CacheHandler::getInstance()->flushAll();
 		
-		
 		return [
 			'pluginName' => $this->packageInstallationPlugin->pluginName,
 			'target' => $this->parameters['target'],
diff --git a/wcfsetup/install/files/lib/system/devtools/package/DevtoolsInstaller.class.php b/wcfsetup/install/files/lib/system/devtools/package/DevtoolsInstaller.class.php
index f1a13899d5..f034dee165 100644
--- a/wcfsetup/install/files/lib/system/devtools/package/DevtoolsInstaller.class.php
+++ b/wcfsetup/install/files/lib/system/devtools/package/DevtoolsInstaller.class.php
@@ -33,4 +33,4 @@ class DevtoolsInstaller extends Installer {
 	public function getTar($source) {
 		return $this->project->getPackageArchive()->getTar();
 	}
-}
\ No newline at end of file
+}
diff --git a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationQueue.class.php b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationQueue.class.php
index 31ff90d0b5..049678df34 100644
--- a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationQueue.class.php
+++ b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationQueue.class.php
@@ -31,4 +31,4 @@ class DevtoolsPackageInstallationQueue extends PackageInstallationQueue {
 			'isApplication' => $project->getPackage()->isApplication
 		]);
 	}
-}
\ No newline at end of file
+}
diff --git a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPip.class.php b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPip.class.php
index 9d778ab80c..c9ca99319f 100644
--- a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPip.class.php
+++ b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPip.class.php
@@ -297,8 +297,6 @@ class DevtoolsPip extends DatabaseObjectDecorator {
 					
 					return $filename;
 			}
-			
-			
 		}
 	}
-}
\ No newline at end of file
+}
-- 
2.20.1