From e61853a4adf02f1ca36a4718a96f90cd322aad44 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Tue, 26 Sep 2023 14:33:26 +0200
Subject: [PATCH] Show warning when replying as an invisible participant

see https://www.woltlab.com/community/thread/301789-warnung-%C3%BCber-dem-editor-wenn-man-ein-unsichtbarer-konversationsteilnehmer-ist/
---
 .../Core/Conversation/Ui/Message/Reply.js     | 22 +++++++++++++++++++
 language/de.xml                               |  1 +
 language/en.xml                               |  1 +
 templates/conversation.tpl                    |  4 ++--
 templates/conversationQuickReply.tpl          |  5 ++++-
 .../Core/Conversation/Ui/Message/Reply.ts     | 20 +++++++++++++++++
 6 files changed, 50 insertions(+), 3 deletions(-)
 create mode 100644 files/js/WoltLabSuite/Core/Conversation/Ui/Message/Reply.js
 create mode 100644 ts/WoltLabSuite/Core/Conversation/Ui/Message/Reply.ts

diff --git a/files/js/WoltLabSuite/Core/Conversation/Ui/Message/Reply.js b/files/js/WoltLabSuite/Core/Conversation/Ui/Message/Reply.js
new file mode 100644
index 0000000..7942cb6
--- /dev/null
+++ b/files/js/WoltLabSuite/Core/Conversation/Ui/Message/Reply.js
@@ -0,0 +1,22 @@
+/**
+ * Handles the quick reply for conversations.
+ *
+ * @author Tim Duesterhus
+ * @copyright 2001-2023 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @woltlabExcludeBundle tiny
+ */
+define(["require", "exports", "tslib", "WoltLabSuite/Core/Ui/Message/Reply"], function (require, exports, tslib_1, Reply_1) {
+    "use strict";
+    Object.defineProperty(exports, "__esModule", { value: true });
+    exports.Reply = void 0;
+    Reply_1 = tslib_1.__importDefault(Reply_1);
+    class Reply extends Reply_1.default {
+        _insertMessage(...args) {
+            this._content.querySelector(".invisibleParticipantWarning")?.remove();
+            super._insertMessage(...args);
+        }
+    }
+    exports.Reply = Reply;
+    exports.default = Reply;
+});
diff --git a/language/de.xml b/language/de.xml
index 68f3da3..73fcf1c 100644
--- a/language/de.xml
+++ b/language/de.xml
@@ -131,6 +131,7 @@
 		<item name="wcf.conversation.error.mailboxIsFull"><![CDATA[{if LANGUAGE_USE_INFORMAL_VARIANT}Du hast{else}Sie haben{/if} das zulässige Limit für Konversationen bereits erreicht und {if LANGUAGE_USE_INFORMAL_VARIANT}kannst{else}können{/if} keine neuen Konversationen starten.]]></item>
 		<item name="wcf.conversation.message.editNote"><![CDATA[{$message->username} hat diese Nachricht {#$message->editCount} Mal editiert, zuletzt: {time time=$message->lastEditTime}.]]></item>
 		<item name="wcf.conversation.noParticipantsWarning"><![CDATA[{if LANGUAGE_USE_INFORMAL_VARIANT}Du bist{else}Sie sind{/if} dabei, auf eine Konversation ohne weitere Teilnehmer zu antworten. Alle anderen Teilnehmer haben diese Konversation verlassen. Niemand wird {if LANGUAGE_USE_INFORMAL_VARIANT}deine{else}Ihre{/if} Nachricht lesen!]]></item>
+		<item name="wcf.conversation.invisibleParticipantWarning"><![CDATA[{if LANGUAGE_USE_INFORMAL_VARIANT}Du bist{else}Sie sind{/if} als unsichtbarer Teilnehmer dabei, auf diese Konversation zu antworten. Eine Antwort wird {if LANGUAGE_USE_INFORMAL_VARIANT}deine{else}Ihre{/if} Teilnahme an dieser Konversation für jeden anderen Teilnehmer sichtbar machen und die Antwort für jeden Teilnehmer sichtbar sein.]]></item>
 		<item name="wcf.conversation.message.permalink"><![CDATA[Permalink zur {#$startIndex}. Nachricht]]></item>
 		<item name="wcf.conversation.markAsRead.doubleClick"><![CDATA[Konversation durch Doppelklick als gelesen markieren]]></item>
 		<item name="wcf.conversation.visibility"><![CDATA[Leseberechtigung]]></item>
diff --git a/language/en.xml b/language/en.xml
index 8cbf192..02cab22 100644
--- a/language/en.xml
+++ b/language/en.xml
@@ -131,6 +131,7 @@
 		<item name="wcf.conversation.error.mailboxIsFull"><![CDATA[You have reached your maximum conversations limit and cannot create new conversations.]]></item>
 		<item name="wcf.conversation.message.editNote"><![CDATA[{$message->username} edited this message {#$message->editCount} times, last: {time time=$message->lastEditTime}.]]></item>
 		<item name="wcf.conversation.noParticipantsWarning"><![CDATA[You are about to reply to a conversation without other participants, nobody is going to read your message!]]></item>
+		<item name="wcf.conversation.invisibleParticipantWarning"><![CDATA[You are about to reply to this conversation as an invisible participant. Sending a reply will make your participation visible to all other participants and the reply will be visible to all participants.]]></item>
 		<item name="wcf.conversation.message.permalink"><![CDATA[Permalink to {#$startIndex}. message]]></item>
 		<item name="wcf.conversation.markAsRead.doubleClick"><![CDATA[Double-Click to Mark This Conversation Read]]></item>
 		<item name="wcf.conversation.visibility"><![CDATA[Read Access]]></item>
diff --git a/templates/conversation.tpl b/templates/conversation.tpl
index 0ad0676..dfde4b6 100644
--- a/templates/conversation.tpl
+++ b/templates/conversation.tpl
@@ -173,8 +173,8 @@
 		});
 		
 		{if $conversation->canReply()}
-			require(['WoltLabSuite/Core/Ui/Message/Reply'], function(UiMessageReply) {
-				new UiMessageReply({
+			require(['WoltLabSuite/Core/Conversation/Ui/Message/Reply'], function({ Reply }) {
+				new Reply({
 					ajax: {
 						className: 'wcf\\data\\conversation\\message\\ConversationMessageAction'
 					},
diff --git a/templates/conversationQuickReply.tpl b/templates/conversationQuickReply.tpl
index b66377f..acb5aa3 100644
--- a/templates/conversationQuickReply.tpl
+++ b/templates/conversationQuickReply.tpl
@@ -5,7 +5,10 @@
 		<div class="messageContent messageQuickReplyContent"{if $pageNo < $pages} data-placeholder="{lang}wcf.conversation.reply{/lang}"{/if}>
 			<div class="messageBody">
 				{if !$conversation->isDraft && !$conversation->hasOtherParticipants()}
-					<p class="warning"  role="status" style="margin-bottom: 14px">{lang}wcf.conversation.noParticipantsWarning{/lang}</p>
+					<p class="warning" role="status">{lang}wcf.conversation.noParticipantsWarning{/lang}</p>
+				{/if}
+				{if $participants[$__wcf->user->userID]->isInvisible}
+					<p class="warning invisibleParticipantWarning" role="status">{lang}wcf.conversation.invisibleParticipantWarning{/lang}</p>
 				{/if}
 
 				{event name='beforeWysiwyg'}
diff --git a/ts/WoltLabSuite/Core/Conversation/Ui/Message/Reply.ts b/ts/WoltLabSuite/Core/Conversation/Ui/Message/Reply.ts
new file mode 100644
index 0000000..56d0ebb
--- /dev/null
+++ b/ts/WoltLabSuite/Core/Conversation/Ui/Message/Reply.ts
@@ -0,0 +1,20 @@
+/**
+ * Handles the quick reply for conversations.
+ *
+ * @author Tim Duesterhus
+ * @copyright 2001-2023 WoltLab GmbH
+ * @license GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @woltlabExcludeBundle tiny
+ */
+
+import UiMessageReply from "WoltLabSuite/Core/Ui/Message/Reply";
+
+export class Reply extends UiMessageReply {
+  _insertMessage(...args: Parameters<UiMessageReply["_insertMessage"]>): ReturnType<UiMessageReply["_insertMessage"]> {
+    this._content.querySelector(".invisibleParticipantWarning")?.remove();
+
+    super._insertMessage(...args);
+  }
+}
+
+export default Reply;
-- 
2.20.1