From e4bb045695731e12d4fc4c1edae191a76182ff79 Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Fri, 27 Jun 2014 14:46:37 +0200 Subject: [PATCH] Deprecating the VersionableDatabaseObject-system The entire design is flawed as it is anything but flexible and forces copying of full table contents rather than being able to specify the columns which should actually be tracked. In addition it does not provide centralized access and management including comparisons. The entire API is now deprecated and will be removed with WCF 2.2. --- .../files/lib/data/VersionableDatabaseObject.class.php | 2 ++ .../files/lib/data/VersionableDatabaseObjectAction.class.php | 2 ++ .../files/lib/data/VersionableDatabaseObjectEditor.class.php | 2 ++ .../lib/system/cache/builder/VersionCacheBuilder.class.php | 2 ++ .../system/package/PackageInstallationDispatcher.class.php | 4 +++- .../install/files/lib/system/version/VersionHandler.class.php | 2 ++ 6 files changed, 13 insertions(+), 1 deletion(-) diff --git a/wcfsetup/install/files/lib/data/VersionableDatabaseObject.class.php b/wcfsetup/install/files/lib/data/VersionableDatabaseObject.class.php index bcd8fca5ad..c5cf4434c4 100644 --- a/wcfsetup/install/files/lib/data/VersionableDatabaseObject.class.php +++ b/wcfsetup/install/files/lib/data/VersionableDatabaseObject.class.php @@ -6,6 +6,8 @@ use wcf\system\version\VersionHandler; /** * Abstract class for all versionable data classes. * + * @deprecated 2.1 - will be removed with WCF 2.2 + * * @author Jeffrey Reichardt * @copyright 2001-2014 WoltLab GmbH * @license GNU Lesser General Public License diff --git a/wcfsetup/install/files/lib/data/VersionableDatabaseObjectAction.class.php b/wcfsetup/install/files/lib/data/VersionableDatabaseObjectAction.class.php index cdb28e48a6..fc109bc4cb 100644 --- a/wcfsetup/install/files/lib/data/VersionableDatabaseObjectAction.class.php +++ b/wcfsetup/install/files/lib/data/VersionableDatabaseObjectAction.class.php @@ -5,6 +5,8 @@ use wcf\system\version\VersionHandler; /** * Abstract class for all versionable data actions. * + * @deprecated 2.1 - will be removed with WCF 2.2 + * * @author Jeffrey Reichardt * @copyright 2001-2014 WoltLab GmbH * @license GNU Lesser General Public License diff --git a/wcfsetup/install/files/lib/data/VersionableDatabaseObjectEditor.class.php b/wcfsetup/install/files/lib/data/VersionableDatabaseObjectEditor.class.php index 130cf3b607..8d310eb7b0 100644 --- a/wcfsetup/install/files/lib/data/VersionableDatabaseObjectEditor.class.php +++ b/wcfsetup/install/files/lib/data/VersionableDatabaseObjectEditor.class.php @@ -5,6 +5,8 @@ use wcf\system\WCF; /** * Abstract class for all versionable editor classes. * + * @deprecated 2.1 - will be removed with WCF 2.2 + * * @author Jeffrey Reichardt * @copyright 2001-2014 WoltLab GmbH * @license GNU Lesser General Public License diff --git a/wcfsetup/install/files/lib/system/cache/builder/VersionCacheBuilder.class.php b/wcfsetup/install/files/lib/system/cache/builder/VersionCacheBuilder.class.php index 290b5e5a2b..32e2a16c3b 100644 --- a/wcfsetup/install/files/lib/system/cache/builder/VersionCacheBuilder.class.php +++ b/wcfsetup/install/files/lib/system/cache/builder/VersionCacheBuilder.class.php @@ -6,6 +6,8 @@ use wcf\system\WCF; /** * Caches the versions for a certain package and object type. * + * @deprecated 2.1 - will be removed with WCF 2.2 + * * @author Jeffrey Reichardt * @copyright 2001-2014 WoltLab GmbH * @license GNU Lesser General Public License diff --git a/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php b/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php index ddf6ab0ef6..24b3972c30 100644 --- a/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php +++ b/wcfsetup/install/files/lib/system/package/PackageInstallationDispatcher.class.php @@ -1082,8 +1082,10 @@ class PackageInstallationDispatcher { } } - /* + /** * Restructure version tables. + * + * @deprecated 2.1 - will be removed with WCF 2.2 */ protected function restructureVersionTables() { $objectTypes = ObjectTypeCache::getInstance()->getObjectTypes('com.woltlab.wcf.versionableObject'); diff --git a/wcfsetup/install/files/lib/system/version/VersionHandler.class.php b/wcfsetup/install/files/lib/system/version/VersionHandler.class.php index 4b99994d2f..eaddfe19c2 100644 --- a/wcfsetup/install/files/lib/system/version/VersionHandler.class.php +++ b/wcfsetup/install/files/lib/system/version/VersionHandler.class.php @@ -7,6 +7,8 @@ use wcf\system\SingletonFactory; /** * Handles versions of DatabaseObjects. * + * @deprecated 2.1 - will be removed with WCF 2.2 + * * @author Jeffrey Reichardt * @copyright 2001-2014 WoltLab GmbH * @license GNU Lesser General Public License -- 2.20.1