From e1a7d248279e375896cf53e9cb980032a84bf83e Mon Sep 17 00:00:00 2001 From: Martin Sperl Date: Tue, 9 Feb 2016 11:47:16 +0000 Subject: [PATCH] serial: bcm2835: fix unsigned int issue with irq Fixes error condition check when requesting the irq, that would not trigger because of uart_port.irq being defined as unsigned int. Reported by: Dan Carpenter Signed-off-by: Martin Sperl Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/8250/8250_bcm2835aux.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_bcm2835aux.c b/drivers/tty/serial/8250/8250_bcm2835aux.c index ecf89f13a13b..e10f1244409b 100644 --- a/drivers/tty/serial/8250/8250_bcm2835aux.c +++ b/drivers/tty/serial/8250/8250_bcm2835aux.c @@ -59,12 +59,12 @@ static int bcm2835aux_serial_probe(struct platform_device *pdev) } /* get the interrupt */ - data->uart.port.irq = platform_get_irq(pdev, 0); - if (data->uart.port.irq < 0) { - dev_err(&pdev->dev, "irq not found - %i", - data->uart.port.irq); - return data->uart.port.irq; + ret = platform_get_irq(pdev, 0); + if (ret < 0) { + dev_err(&pdev->dev, "irq not found - %i", ret); + return ret; } + data->uart.port.irq = ret; /* map the main registers */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.20.1