From deb235cdd8bfc31533ba1616249c30328247fff2 Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Tue, 28 Jun 2016 12:15:03 +0200 Subject: [PATCH] Using generic name fro user-created cronjobs --- .../lib/acp/form/CronjobAddForm.class.php | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/wcfsetup/install/files/lib/acp/form/CronjobAddForm.class.php b/wcfsetup/install/files/lib/acp/form/CronjobAddForm.class.php index c0941b1753..530213ee21 100755 --- a/wcfsetup/install/files/lib/acp/form/CronjobAddForm.class.php +++ b/wcfsetup/install/files/lib/acp/form/CronjobAddForm.class.php @@ -1,5 +1,6 @@ additionalFields, [ 'className' => $this->className, 'packageID' => $this->packageID, + 'cronjobName' => 'com.woltlab.wcf.cronjob', 'description' => $this->description, 'startMinute' => $this->startMinute, 'startHour' => $this->startHour, @@ -161,20 +163,23 @@ class CronjobAddForm extends AbstractForm { ]); $this->objectAction = new CronjobAction([], 'create', ['data' => $data]); - $this->objectAction->executeAction(); + /** @var Cronjob $cronjob */ + $cronjob = $this->objectAction->executeAction()['returnValues']; + $cronjobID = $cronjob->cronjobID; + + // update `cronjobName` + $data = ['cronjobName' => 'com.woltlab.wcf.cronjob' . $cronjobID]; if (!I18nHandler::getInstance()->isPlainValue('description')) { - $returnValues = $this->objectAction->getReturnValues(); - $cronjobID = $returnValues['returnValues']->cronjobID; I18nHandler::getInstance()->save('description', 'wcf.acp.cronjob.description.cronjob'.$cronjobID, 'wcf.acp.cronjob', $this->packageID); // update group name - $cronjobEditor = new CronjobEditor($returnValues['returnValues']); - $cronjobEditor->update([ - 'description' => 'wcf.acp.cronjob.description.cronjob'.$cronjobID - ]); + $data['description'] = 'wcf.acp.cronjob.description.cronjob' . $cronjobID; } + $cronjobEditor = new CronjobEditor($cronjob); + $cronjobEditor->update($data); + $this->saved(); // reset values -- 2.20.1