From db64bcf387aae6c7afad122a529d7d0513d3c5db Mon Sep 17 00:00:00 2001 From: Tejun Heo <htejun@gmail.com> Date: Wed, 31 Oct 2007 10:17:06 +0900 Subject: [PATCH] libata: request PHY speed configuration on SControl access failure In sata_set_spd_needed(), if SControl read failed, it returned 0 and skipped PHY speed configuration. However, if SControl access fails, it's far more logical to request PHY speed configuration. Reverse the logic. Signed-off-by: Tejun Heo <htejun@gmail.com> Signed-off-by: Jeff Garzik <jeff@garzik.org> --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 24b3bd63621f..3a1ec4e715ed 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2784,7 +2784,7 @@ int sata_set_spd_needed(struct ata_link *link) u32 scontrol; if (sata_scr_read(link, SCR_CONTROL, &scontrol)) - return 0; + return 1; return __sata_set_spd_needed(link, &scontrol); } -- 2.20.1