From d5bf6922334c7322ca6e44743e02bdc5f5853730 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Tue, 15 Sep 2020 12:52:49 +0200
Subject: [PATCH] Add HtmlOutputNodePre::guessHighlighter()

This nicely contains the guessing logic within a single function, improving
readability.
---
 .../output/node/HtmlOutputNodePre.class.php   | 95 +++++++++++--------
 1 file changed, 54 insertions(+), 41 deletions(-)

diff --git a/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodePre.class.php b/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodePre.class.php
index a546ab6ee8..84a3d9895a 100644
--- a/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodePre.class.php
+++ b/wcfsetup/install/files/lib/system/html/output/node/HtmlOutputNodePre.class.php
@@ -108,47 +108,7 @@ class HtmlOutputNodePre extends AbstractHtmlOutputNode {
 		}
 		
 		if (!$highlighter) {
-			// try to guess highlighter
-			if (mb_strpos($content, '<?php') !== false) {
-				$highlighter = 'php';
-			}
-			else if (mb_strpos($content, '<html') !== false) {
-				$highlighter = 'html';
-			}
-			else if (mb_strpos($content, '<?xml') === 0) {
-				$highlighter = 'xml';
-			}
-			else if (	mb_strpos($content, 'SELECT') === 0
-				||	mb_strpos($content, 'UPDATE') === 0
-				||	mb_strpos($content, 'INSERT') === 0
-				||	mb_strpos($content, 'DELETE') === 0) {
-				$highlighter = 'sql';
-			}
-			else if (mb_strpos($content, 'import java.') !== false) {
-				$highlighter = 'java';
-			}
-			else if (	mb_strpos($content, "---") !== false
-				&&	mb_strpos($content, "\n+++") !== false) {
-				$highlighter = 'diff';
-			}
-			else if (mb_strpos($content, "\n#include ") !== false) {
-				$highlighter = 'c';
-			}
-			else if (mb_strpos($content, '#!/usr/bin/perl') === 0) {
-				$highlighter = 'perl';
-			}
-			else if (mb_strpos($content, 'def __init__(self') !== false) {
-				$highlighter = 'python';
-			}
-			else if (Regex::compile('^#!/bin/(ba|z)?sh')->match($content)) {
-				$highlighter = 'bash';
-			}
-			else if (mb_strpos($content, '\\documentclass') !== false) {
-				$highlighter = 'latex';
-			}
-			else if (mb_strpos($content, '!important;') !== false) {
-				$highlighter = 'css';
-			}
+			$highlighter = $this->guessHighlighter($content);
 		}
 		$eventData = [
 			'highlighter' => $highlighter,
@@ -190,6 +150,59 @@ class HtmlOutputNodePre extends AbstractHtmlOutputNode {
 		return WCF::getTPL()->fetch('codeMetaCode');
 	}
 	
+	/**
+	 * Returns a likely highlighter for the given content.
+	 * 
+	 * @param string $content
+	 * @return string
+	 */
+	public function guessHighlighter($content) {
+		$highlighter = '';
+		
+		if (mb_strpos($content, '<?php') !== false) {
+			$highlighter = 'php';
+		}
+		else if (mb_strpos($content, '<html') !== false) {
+			$highlighter = 'html';
+		}
+		else if (mb_strpos($content, '<?xml') === 0) {
+			$highlighter = 'xml';
+		}
+		else if (	mb_strpos($content, 'SELECT') === 0
+			||	mb_strpos($content, 'UPDATE') === 0
+			||	mb_strpos($content, 'INSERT') === 0
+			||	mb_strpos($content, 'DELETE') === 0) {
+			$highlighter = 'sql';
+		}
+		else if (mb_strpos($content, 'import java.') !== false) {
+			$highlighter = 'java';
+		}
+		else if (	mb_strpos($content, "---") !== false
+			&&	mb_strpos($content, "\n+++") !== false) {
+			$highlighter = 'diff';
+		}
+		else if (mb_strpos($content, "\n#include ") !== false) {
+			$highlighter = 'c';
+		}
+		else if (mb_strpos($content, '#!/usr/bin/perl') === 0) {
+			$highlighter = 'perl';
+		}
+		else if (mb_strpos($content, 'def __init__(self') !== false) {
+			$highlighter = 'python';
+		}
+		else if (Regex::compile('^#!/bin/(ba|z)?sh')->match($content)) {
+			$highlighter = 'bash';
+		}
+		else if (mb_strpos($content, '\\documentclass') !== false) {
+			$highlighter = 'latex';
+		}
+		else if (mb_strpos($content, '!important;') !== false) {
+			$highlighter = 'css';
+		}
+		
+		return $highlighter;
+	}
+	
 	/**
 	 * Returns a unique ID for this code block.
 	 *
-- 
2.20.1