From d2ab0b0c4c2570921a9ec1eff1e3a5143e05b231 Mon Sep 17 00:00:00 2001 From: "J. Bruce Fields" Date: Sat, 30 Jun 2007 12:40:32 -0400 Subject: [PATCH] locks: convert an -EINVAL return to a BUG There's no point trying to return an error in these cases, which all represent bugs in the callers. Signed-off-by: J. Bruce Fields --- fs/locks.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/locks.c b/fs/locks.c index 924e4a7fb1d5..3c23fd261022 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -1348,9 +1348,7 @@ static int __setlease(struct file *filp, long arg, struct file_lock **flp) time_out_leases(inode); - error = -EINVAL; - if (!flp || !(*flp) || !(*flp)->fl_lmops || !(*flp)->fl_lmops->fl_break) - goto out; + BUG_ON(!(*flp)->fl_lmops->fl_break); lease = *flp; -- 2.20.1