From ce61856bd2aadb064f595e5c0444376a2b117c41 Mon Sep 17 00:00:00 2001 From: Eric Paris Date: Thu, 11 Jun 2009 11:09:47 -0400 Subject: [PATCH] dnotify: do not bother to lock entry->lock when reading mask entry->lock is needed to make sure entry->mask does not change while manipulating it. In dnotify_should_send_event() we don't care if we get an old or a new mask value out of this entry so there is no point it taking the lock. Signed-off-by: Eric Paris --- fs/notify/dnotify/dnotify.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 5134e898f60d..ec459b6e8c64 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c @@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group, if (!entry) return false; - spin_lock(&entry->lock); send = (mask & entry->mask); - spin_unlock(&entry->lock); + fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */ return send; -- 2.20.1