From ce147c7445c28fcf38813f62b2a2bb1266db9ef4 Mon Sep 17 00:00:00 2001 From: Vineet Gupta Date: Sat, 6 Apr 2013 17:11:58 +0530 Subject: [PATCH] ARC: unaligned access emulation broken if callee-reg dest of LD/ST The fixup code correctly updates the callee-regs on stack, but fails to unwind it into actual register file. Thus userspace won't see the update. Reported-by: Noam Camus Signed-off-by: Vineet Gupta --- arch/arc/kernel/entry.S | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arc/kernel/entry.S b/arch/arc/kernel/entry.S index 666a486f1e7b..0c6d664d4a83 100644 --- a/arch/arc/kernel/entry.S +++ b/arch/arc/kernel/entry.S @@ -396,7 +396,9 @@ ARC_ENTRY EV_TLBProtV bl do_misaligned_access - DISCARD_CALLEE_SAVED_USER + ; TBD: optimize - do this only if a callee reg was involved + ; either a dst of emulated LD/ST or src with address-writeback + RESTORE_CALLEE_SAVED_USER #else bl do_misaligned_error #endif -- 2.20.1