From cd9ae9e4db8a62cfbdaec2d73f8c34eea66c48d5 Mon Sep 17 00:00:00 2001 From: sayli karnik Date: Mon, 19 Sep 2016 20:02:40 +0530 Subject: [PATCH] staging: i4l: act2000: Move assignment out of if statement This patch places assignments which are inside the if condition, above it. Done using coccinelle: @@ statement s; expression e; identifier id; @@ - if ((id = e)) + id = e; + if (id) s Signed-off-by: sayli karnik Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman --- drivers/staging/i4l/act2000/module.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/module.c b/drivers/staging/i4l/act2000/module.c index 39a8940b6ae5..99c9c0a1c63e 100644 --- a/drivers/staging/i4l/act2000/module.c +++ b/drivers/staging/i4l/act2000/module.c @@ -289,7 +289,8 @@ act2000_command(act2000_card *card, isdn_ctrl *c) if (copy_from_user(tmp, arg, sizeof(tmp))) return -EFAULT; - if ((ret = act2000_set_msn(card, tmp))) + ret = act2000_set_msn(card, tmp); + if (ret) return ret; if (card->flags & ACT2000_FLAGS_RUNNING) return (actcapi_manufacturer_req_msn(card)); -- 2.20.1