From cbac57d0c3e2ee88f502c7008881bf261f5e7f16 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim=20D=C3=BCsterhus?= Date: Fri, 9 Jul 2021 15:21:35 +0200 Subject: [PATCH] Move the CodeMirror upgrade information to libraries.md (#204) --- docs/migration/wsc54/javascript.md | 10 +++------- docs/migration/wsc54/libraries.md | 9 +++++++++ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/migration/wsc54/javascript.md b/docs/migration/wsc54/javascript.md index cb74f11c..d4cb8cf9 100644 --- a/docs/migration/wsc54/javascript.md +++ b/docs/migration/wsc54/javascript.md @@ -14,14 +14,10 @@ Be aware that the new color picker requires the following new phrases to be avai - `wcf.style.colorPicker.hexAlpha`, - `wcf.style.colorPicker.new`. -See [WoltLab/WCF#4353](https://github.com/WoltLab/WCF/pull/4353) for more information. - +See [WoltLab/WCF#4353](https://github.com/WoltLab/WCF/pull/4353) for details. ## CodeMirror -CodeMirror, the code editor we use for editing templates and SCSS, for example, has been updated to version 5.61.1 and we now also deliver all supported languages/modes. -To properly support all languages/modes, CodeMirror is now loaded via the AMD module loader, which requires the original structure of the CodeMirror package, i.e. `codemirror.js` being in a `lib` folder. -To preserve backward-compatibility, we also keep copies of `codemirror.js` and `codemirror.css` in version 5.61.1 directly in `js/3rdParty/codemirror`. -These files are, however, considered deprecated and you should migrate to using `require()` (see `codemirror` ACP template). +The bundled version of CodeMirror was updated and should be loaded using the AMD loader going forward. -See [WoltLab/WCF#4277](https://github.com/WoltLab/WCF/pull/4277) for more information. +See the [third party libraries migration guide](libraries.md#codemirror) for details. diff --git a/docs/migration/wsc54/libraries.md b/docs/migration/wsc54/libraries.md index 44e797d0..9aff2455 100644 --- a/docs/migration/wsc54/libraries.md +++ b/docs/migration/wsc54/libraries.md @@ -9,3 +9,12 @@ If you interact with scssphp only by deploying `.scss` files, then you should no If you happen to directly use scssphp in your PHP code, you should be aware that scssphp deprecated the use of the `compile()` method, non-UTF-8 processing and also adjusted the handling of pure PHP values for variable handling. Refer to [WoltLab/WCF#4345](https://github.com/WoltLab/WCF/pull/4345) and the [scssphp releases](https://github.com/scssphp/scssphp/releases) for details. + +## CodeMirror + +CodeMirror, the code editor we use for editing templates and SCSS, for example, has been updated to version 5.61.1 and we now also deliver all supported languages/modes. +To properly support all languages/modes, CodeMirror is now loaded via the AMD module loader, which requires the original structure of the CodeMirror package, i.e. `codemirror.js` being in a `lib` folder. +To preserve backward-compatibility, we also keep copies of `codemirror.js` and `codemirror.css` in version 5.61.1 directly in `js/3rdParty/codemirror`. +These files are, however, considered deprecated and you should migrate to using `require()` (see `codemirror` ACP template). + +See [WoltLab/WCF#4277](https://github.com/WoltLab/WCF/pull/4277) for details. -- 2.20.1