From cb1ca0b3bb6681310e7fe9d29d6d4c76dd71801d Mon Sep 17 00:00:00 2001 From: Jassi Brar Date: Wed, 4 Nov 2015 08:57:22 +0530 Subject: [PATCH] mailbox: mailbox-test: avoid reading iomem twice Don't pass mmio region as source to print_hex_dump() and then again to memcpy_fromio(). Do it once and give print_hex_dump() the buffer we just read the data in. Acked-by: Lee Jones Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox-test.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mailbox/mailbox-test.c b/drivers/mailbox/mailbox-test.c index f82dc8926687..684ae17dcf39 100644 --- a/drivers/mailbox/mailbox-test.c +++ b/drivers/mailbox/mailbox-test.c @@ -221,11 +221,10 @@ static void mbox_test_receive_message(struct mbox_client *client, void *message) spin_lock_irqsave(&tdev->lock, flags); if (tdev->mmio) { + memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN); print_hex_dump(KERN_INFO, "Client: Received [MMIO]: ", DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1, - __io_virt(tdev->mmio), MBOX_MAX_MSG_LEN, true); - memcpy_fromio(tdev->rx_buffer, tdev->mmio, MBOX_MAX_MSG_LEN); - + tdev->rx_buffer, MBOX_MAX_MSG_LEN, true); } else if (message) { print_hex_dump(KERN_INFO, "Client: Received [API]: ", DUMP_PREFIX_ADDRESS, MBOX_BYTES_PER_LINE, 1, -- 2.20.1