From ca1004bab9c6829e64036f7da5e25a698756ee28 Mon Sep 17 00:00:00 2001 From: Mark Brown Date: Sat, 16 Jul 2011 11:34:58 +0900 Subject: [PATCH] ASoC: Report an error for unknown adav80x formats Not only fixes error handling but also some uninitialized variable warnings. Signed-off-by: Mark Brown Acked-by: Lars-Peter Clausen --- sound/soc/codecs/adav80x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/adav80x.c b/sound/soc/codecs/adav80x.c index e30fba62392d..300c04b70e71 100644 --- a/sound/soc/codecs/adav80x.c +++ b/sound/soc/codecs/adav80x.c @@ -456,7 +456,7 @@ static int adav80x_set_capture_pcm_format(struct snd_soc_codec *codec, val = ADAV80X_CAPTURE_WORD_LEN24; break; default: - break; + return -EINVAL; } snd_soc_update_bits(codec, adav80x_port_ctrl_regs[dai->id][0], @@ -488,7 +488,7 @@ static int adav80x_set_playback_pcm_format(struct snd_soc_codec *codec, val = ADAV80X_PLAYBACK_MODE_RIGHT_J_24; break; default: - break; + return -EINVAL; } snd_soc_update_bits(codec, adav80x_port_ctrl_regs[dai->id][1], -- 2.20.1