From c6d64a19cdb39680460ab9f153e33843aa8c825c Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Tue, 19 Jan 2016 12:51:24 +0100 Subject: [PATCH] greybus: connection: drop the connection_mutex Drop the useless connection_mutex that did not, and can not be used to prevent connection lookup races in atomic context and therefore serves no purpose. Reviewed-by: Viresh Kumar Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/connection.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index 1d7c21e03bfa..bfd2c0dee056 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -66,8 +66,6 @@ void greybus_data_rcvd(struct gb_host_device *hd, u16 cport_id, } EXPORT_SYMBOL_GPL(greybus_data_rcvd); -static DEFINE_MUTEX(connection_mutex); - static void gb_connection_kref_release(struct kref *kref) { struct gb_connection *connection; @@ -75,7 +73,6 @@ static void gb_connection_kref_release(struct kref *kref) connection = container_of(kref, struct gb_connection, kref); kfree(connection); - mutex_unlock(&connection_mutex); } static void gb_connection_init_name(struct gb_connection *connection) @@ -519,8 +516,7 @@ void gb_connection_destroy(struct gb_connection *connection) ida_simple_remove(id_map, connection->hd_cport_id); connection->hd_cport_id = CPORT_ID_BAD; - kref_put_mutex(&connection->kref, gb_connection_kref_release, - &connection_mutex); + kref_put(&connection->kref, gb_connection_kref_release); } void gb_connection_latency_tag_enable(struct gb_connection *connection) -- 2.20.1