From c1109558ae0f07a3434357cd26203bfc7adfea75 Mon Sep 17 00:00:00 2001 From: Trond Myklebust Date: Thu, 29 May 2014 11:38:15 -0400 Subject: [PATCH] NFS: Fix error handling in __nfs_pageio_add_request Handle the case where nfs_create_request() returns an error. Reported-by: Dan Carpenter Signed-off-by: Trond Myklebust --- fs/nfs/pagelist.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c index fab78d13ee14..0b8446f1008d 100644 --- a/fs/nfs/pagelist.c +++ b/fs/nfs/pagelist.c @@ -947,6 +947,8 @@ static int __nfs_pageio_add_request(struct nfs_pageio_descriptor *desc, subreq = nfs_create_request(req->wb_context, req->wb_page, subreq, pgbase, bytes_left); + if (IS_ERR(subreq)) + goto err_ptr; nfs_lock_request(subreq); subreq->wb_offset = offset; subreq->wb_index = req->wb_index; @@ -955,6 +957,10 @@ static int __nfs_pageio_add_request(struct nfs_pageio_descriptor *desc, nfs_page_group_unlock(req); return 1; +err_ptr: + desc->pg_error = PTR_ERR(subreq); + nfs_page_group_unlock(req); + return 0; } static int nfs_do_recoalesce(struct nfs_pageio_descriptor *desc) -- 2.20.1