From be03f34230d0e68859c6eb3e68d57df1414f9ae0 Mon Sep 17 00:00:00 2001 From: Matthias Schmidt Date: Thu, 26 May 2016 16:27:22 +0200 Subject: [PATCH] Add @noinspection PhpMissingParentCallCommonInspection tags --- files/lib/data/conversation/ConversationAction.class.php | 1 + .../data/conversation/ConversationParticipantList.class.php | 2 ++ files/lib/data/conversation/FeedConversationList.class.php | 1 + files/lib/data/conversation/ViewableConversation.class.php | 5 +++++ .../message/SearchResultConversationMessage.class.php | 3 +++ .../log/ConversationLogModificationLogList.class.php | 1 + files/lib/form/ConversationMessageAddForm.class.php | 5 ++++- files/lib/form/ConversationMessageEditForm.class.php | 3 +++ files/lib/page/ConversationListPage.class.php | 1 + .../ConversationMessageAttachmentObjectType.class.php | 4 ++++ .../cache/runtime/UserConversationRuntimeCache.class.php | 1 + .../page/handler/ConversationListPageHandler.class.php | 2 ++ files/lib/system/search/ConversationMessageSearch.class.php | 6 ++++++ .../ConversationMessageUserNotificationEvent.class.php | 3 +++ .../event/ConversationUserNotificationEvent.class.php | 2 ++ .../type/ConversationNotificationObjectType.class.php | 1 + .../worker/ConversationMessageRebuildDataWorker.class.php | 2 ++ .../system/worker/ConversationRebuildDataWorker.class.php | 2 ++ 18 files changed, 44 insertions(+), 1 deletion(-) diff --git a/files/lib/data/conversation/ConversationAction.class.php b/files/lib/data/conversation/ConversationAction.class.php index 9154ad2..487e316 100644 --- a/files/lib/data/conversation/ConversationAction.class.php +++ b/files/lib/data/conversation/ConversationAction.class.php @@ -50,6 +50,7 @@ class ConversationAction extends AbstractDatabaseObjectAction implements IClipbo */ protected $conversationData = []; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc * @return Conversation diff --git a/files/lib/data/conversation/ConversationParticipantList.class.php b/files/lib/data/conversation/ConversationParticipantList.class.php index 702156c..6c200d7 100644 --- a/files/lib/data/conversation/ConversationParticipantList.class.php +++ b/files/lib/data/conversation/ConversationParticipantList.class.php @@ -53,6 +53,7 @@ class ConversationParticipantList extends UserProfileList { $this->sqlJoins .= " LEFT JOIN wcf".WCF_N."_conversation_to_user conversation_to_user ON (conversation_to_user.participantID = user_table.userID AND conversation_to_user.conversationID = ".$conversationID.")"; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -67,6 +68,7 @@ class ConversationParticipantList extends UserProfileList { return $row['count']; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/data/conversation/FeedConversationList.class.php b/files/lib/data/conversation/FeedConversationList.class.php index ff9d10d..bcbbdcc 100644 --- a/files/lib/data/conversation/FeedConversationList.class.php +++ b/files/lib/data/conversation/FeedConversationList.class.php @@ -28,6 +28,7 @@ class FeedConversationList extends ConversationList { */ public $sqlOrderBy = 'conversation.lastPostTime DESC'; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/data/conversation/ViewableConversation.class.php b/files/lib/data/conversation/ViewableConversation.class.php index 51559de..48f868d 100644 --- a/files/lib/data/conversation/ViewableConversation.class.php +++ b/files/lib/data/conversation/ViewableConversation.class.php @@ -10,6 +10,11 @@ use wcf\system\cache\runtime\UserProfileRuntimeCache; use wcf\system\database\util\PreparedStatementConditionBuilder; use wcf\system\WCF; +/** @noinspection PhpMissingParentCallCommonInspection */ +/** @noinspection PhpMissingParentCallCommonInspection */ +/** @noinspection PhpMissingParentCallCommonInspection */ +/** @noinspection PhpMissingParentCallCommonInspection */ + /** * Represents a viewable conversation. * diff --git a/files/lib/data/conversation/message/SearchResultConversationMessage.class.php b/files/lib/data/conversation/message/SearchResultConversationMessage.class.php index 28a8774..49faf3f 100644 --- a/files/lib/data/conversation/message/SearchResultConversationMessage.class.php +++ b/files/lib/data/conversation/message/SearchResultConversationMessage.class.php @@ -24,6 +24,7 @@ class SearchResultConversationMessage extends ViewableConversationMessage implem */ public $conversation = null; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * Returns the conversation object. * @@ -40,6 +41,7 @@ class SearchResultConversationMessage extends ViewableConversationMessage implem return $this->conversation; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -69,6 +71,7 @@ class SearchResultConversationMessage extends ViewableConversationMessage implem return $this->getDecoratedObject()->getLink(); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/data/modification/log/ConversationLogModificationLogList.class.php b/files/lib/data/modification/log/ConversationLogModificationLogList.class.php index 67ee2a5..f32fbb9 100644 --- a/files/lib/data/modification/log/ConversationLogModificationLogList.class.php +++ b/files/lib/data/modification/log/ConversationLogModificationLogList.class.php @@ -31,6 +31,7 @@ class ConversationLogModificationLogList extends ModificationLogList { $this->getConditionBuilder()->add('modification_log.objectID = ?', [$conversationID]); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/form/ConversationMessageAddForm.class.php b/files/lib/form/ConversationMessageAddForm.class.php index 29880cb..302c08d 100644 --- a/files/lib/form/ConversationMessageAddForm.class.php +++ b/files/lib/form/ConversationMessageAddForm.class.php @@ -91,10 +91,13 @@ class ConversationMessageAddForm extends MessageForm { MessageQuoteManager::getInstance()->readFormParameters(); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ - protected function validateSubject() {} + protected function validateSubject() { + // does nothing + } /** * @inheritDoc diff --git a/files/lib/form/ConversationMessageEditForm.class.php b/files/lib/form/ConversationMessageEditForm.class.php index 6901ac6..fe54f3e 100644 --- a/files/lib/form/ConversationMessageEditForm.class.php +++ b/files/lib/form/ConversationMessageEditForm.class.php @@ -64,6 +64,7 @@ class ConversationMessageEditForm extends ConversationAddForm { */ public $isFirstMessage = false; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -114,6 +115,7 @@ class ConversationMessageEditForm extends ConversationAddForm { if ($this->isFirstMessage) parent::validateSubject(); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -181,6 +183,7 @@ class ConversationMessageEditForm extends ConversationAddForm { exit; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/page/ConversationListPage.class.php b/files/lib/page/ConversationListPage.class.php index a1e774b..38e54c8 100644 --- a/files/lib/page/ConversationListPage.class.php +++ b/files/lib/page/ConversationListPage.class.php @@ -142,6 +142,7 @@ class ConversationListPage extends SortablePage { if (isset($_REQUEST['participants'])) $this->participants = ArrayUtil::trim(explode(',', $_REQUEST['participants'])); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/attachment/ConversationMessageAttachmentObjectType.class.php b/files/lib/system/attachment/ConversationMessageAttachmentObjectType.class.php index f8942c5..4c463ec 100644 --- a/files/lib/system/attachment/ConversationMessageAttachmentObjectType.class.php +++ b/files/lib/system/attachment/ConversationMessageAttachmentObjectType.class.php @@ -19,6 +19,7 @@ use wcf\util\ArrayUtil; * @method ConversationMessage getObject($objectID) */ class ConversationMessageAttachmentObjectType extends AbstractAttachmentObjectType { + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -26,6 +27,7 @@ class ConversationMessageAttachmentObjectType extends AbstractAttachmentObjectTy return WCF::getSession()->getPermission('user.conversation.maxAttachmentSize'); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -33,6 +35,7 @@ class ConversationMessageAttachmentObjectType extends AbstractAttachmentObjectTy return ArrayUtil::trim(explode("\n", WCF::getSession()->getPermission('user.conversation.allowedAttachmentExtensions'))); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -105,6 +108,7 @@ class ConversationMessageAttachmentObjectType extends AbstractAttachmentObjectTy } } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/cache/runtime/UserConversationRuntimeCache.class.php b/files/lib/system/cache/runtime/UserConversationRuntimeCache.class.php index 26ce6e4..43ed4bf 100644 --- a/files/lib/system/cache/runtime/UserConversationRuntimeCache.class.php +++ b/files/lib/system/cache/runtime/UserConversationRuntimeCache.class.php @@ -24,6 +24,7 @@ class UserConversationRuntimeCache extends AbstractRuntimeCache { */ protected $listClassName = UserConversationList::class; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/page/handler/ConversationListPageHandler.class.php b/files/lib/system/page/handler/ConversationListPageHandler.class.php index df85cd3..867946a 100644 --- a/files/lib/system/page/handler/ConversationListPageHandler.class.php +++ b/files/lib/system/page/handler/ConversationListPageHandler.class.php @@ -15,6 +15,7 @@ use wcf\system\WCF; * @since 2.2 */ class ConversationListPageHandler extends AbstractMenuPageHandler { + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -22,6 +23,7 @@ class ConversationListPageHandler extends AbstractMenuPageHandler { return ConversationHandler::getInstance()->getUnreadConversationCount(); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/search/ConversationMessageSearch.class.php b/files/lib/system/search/ConversationMessageSearch.class.php index 5c53012..e76d7b9 100644 --- a/files/lib/system/search/ConversationMessageSearch.class.php +++ b/files/lib/system/search/ConversationMessageSearch.class.php @@ -49,6 +49,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { } } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -66,6 +67,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { return null; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -88,6 +90,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { return $this->getTableName().'.messageID'; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -95,6 +98,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { return 'conversation.subject'; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -111,6 +115,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { return $conditionBuilder; } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -118,6 +123,7 @@ class ConversationMessageSearch extends AbstractSearchableObjectType { return (WCF::getUser()->userID ? true : false); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/user/notification/event/ConversationMessageUserNotificationEvent.class.php b/files/lib/system/user/notification/event/ConversationMessageUserNotificationEvent.class.php index 8857cbd..4f369dd 100644 --- a/files/lib/system/user/notification/event/ConversationMessageUserNotificationEvent.class.php +++ b/files/lib/system/user/notification/event/ConversationMessageUserNotificationEvent.class.php @@ -56,6 +56,7 @@ class ConversationMessageUserNotificationEvent extends AbstractUserNotificationE ]); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -77,6 +78,7 @@ class ConversationMessageUserNotificationEvent extends AbstractUserNotificationE ], '#message'.$this->getUserNotificationObject()->messageID); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -84,6 +86,7 @@ class ConversationMessageUserNotificationEvent extends AbstractUserNotificationE return sha1($this->eventID . '-' . $this->getUserNotificationObject()->conversationID); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/user/notification/event/ConversationUserNotificationEvent.class.php b/files/lib/system/user/notification/event/ConversationUserNotificationEvent.class.php index 6979b2a..e17bddb 100644 --- a/files/lib/system/user/notification/event/ConversationUserNotificationEvent.class.php +++ b/files/lib/system/user/notification/event/ConversationUserNotificationEvent.class.php @@ -33,6 +33,7 @@ class ConversationUserNotificationEvent extends AbstractUserNotificationEvent { ]); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -51,6 +52,7 @@ class ConversationUserNotificationEvent extends AbstractUserNotificationEvent { return LinkHandler::getInstance()->getLink('Conversation', ['object' => $this->userNotificationObject]); } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/user/notification/object/type/ConversationNotificationObjectType.class.php b/files/lib/system/user/notification/object/type/ConversationNotificationObjectType.class.php index c75f6a0..3ec96a3 100644 --- a/files/lib/system/user/notification/object/type/ConversationNotificationObjectType.class.php +++ b/files/lib/system/user/notification/object/type/ConversationNotificationObjectType.class.php @@ -31,6 +31,7 @@ class ConversationNotificationObjectType extends AbstractUserNotificationObjectT */ protected static $objectListClassName = ConversationList::class; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/worker/ConversationMessageRebuildDataWorker.class.php b/files/lib/system/worker/ConversationMessageRebuildDataWorker.class.php index e813ef6..62dea32 100644 --- a/files/lib/system/worker/ConversationMessageRebuildDataWorker.class.php +++ b/files/lib/system/worker/ConversationMessageRebuildDataWorker.class.php @@ -23,6 +23,7 @@ class ConversationMessageRebuildDataWorker extends AbstractRebuildDataWorker { */ protected $limit = 500; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -38,6 +39,7 @@ class ConversationMessageRebuildDataWorker extends AbstractRebuildDataWorker { } } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ diff --git a/files/lib/system/worker/ConversationRebuildDataWorker.class.php b/files/lib/system/worker/ConversationRebuildDataWorker.class.php index 2a8491d..31916ba 100644 --- a/files/lib/system/worker/ConversationRebuildDataWorker.class.php +++ b/files/lib/system/worker/ConversationRebuildDataWorker.class.php @@ -22,6 +22,7 @@ class ConversationRebuildDataWorker extends AbstractRebuildDataWorker { */ protected $limit = 100; + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ @@ -37,6 +38,7 @@ class ConversationRebuildDataWorker extends AbstractRebuildDataWorker { } } + /** @noinspection PhpMissingParentCallCommonInspection */ /** * @inheritDoc */ -- 2.20.1