From bc8eadd46c05280f7ddcf2ab7cf97d1cd15a578c Mon Sep 17 00:00:00 2001 From: Vaibhav Hiremath Date: Sat, 13 Feb 2016 02:04:19 +0530 Subject: [PATCH] greybus: arche-apb-ctrl: Do not export any gpios With addition of operational state in driver, user/developer can switch to FW flashing state through sysfs. So no need to export any gpios to userspace now. Testing Done: Tested on EVT1.2 and DB3.5 platform Signed-off-by: Vaibhav Hiremath Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/arche-apb-ctrl.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index e1df998ca877..b888da376b21 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -58,17 +58,6 @@ static inline void assert_reset(unsigned int gpio) gpio_set_value(gpio, 0); } -/* Export gpio's to user space */ -static void export_gpios(struct arche_apb_ctrl_drvdata *apb) -{ - gpio_export(apb->resetn_gpio, false); -} - -static void unexport_gpios(struct arche_apb_ctrl_drvdata *apb) -{ - gpio_unexport(apb->resetn_gpio); -} - /* * Note: Please do not modify the below sequence, as it is as per the spec */ @@ -407,20 +396,15 @@ int arche_apb_ctrl_probe(struct platform_device *pdev) return ret; } - export_gpios(apb); - dev_info(&pdev->dev, "Device registered successfully\n"); return 0; } int arche_apb_ctrl_remove(struct platform_device *pdev) { - struct arche_apb_ctrl_drvdata *apb = platform_get_drvdata(pdev); - device_remove_file(&pdev->dev, &dev_attr_state); poweroff_seq(pdev); platform_set_drvdata(pdev, NULL); - unexport_gpios(apb); return 0; } -- 2.20.1