From b78fb2835f5aca15098fe1ad24a08745a5e1e9f8 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <timwolla@arcor.de>
Date: Mon, 22 Aug 2011 17:07:14 +0200
Subject: [PATCH] Implemented dtdesign's suggestions

---
 .../files/lib/data/cronjob/CronjobAction.class.php       | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/wcfsetup/install/files/lib/data/cronjob/CronjobAction.class.php b/wcfsetup/install/files/lib/data/cronjob/CronjobAction.class.php
index c351702843..4692331d12 100644
--- a/wcfsetup/install/files/lib/data/cronjob/CronjobAction.class.php
+++ b/wcfsetup/install/files/lib/data/cronjob/CronjobAction.class.php
@@ -1,6 +1,7 @@
 <?php
 namespace wcf\data\cronjob;
 use wcf\data\AbstractDatabaseObjectAction;
+use wcf\data\cronjob\log\CronjobLogEditor;
 use wcf\system\WCF;
 use wcf\util\DateUtil;
 
@@ -115,20 +116,18 @@ class CronjobAction extends AbstractDatabaseObjectAction {
 			$executable = new $className();
 			
 			// execute cronjob
-			$success = true;
 			$error = '';
 			try {
 				$executable->execute(new Cronjob($cronjob->cronjobID));
 			}
 			catch (\Exception $e) {
-				$success = false;
-				$error = (string) $e;
+				$error = $e->getMessage();
 			}
 			
-			log\CronjobLogEditor::create(array(
+			CronjobLogEditor::create(array(
 				'cronjobID' => $cronjob->cronjobID,
 				'execTime' => TIME_NOW,
-				'success' => (int) $success,
+				'success' => (int) ($error != ''),
 				'error' => $error
 			));
 				
-- 
2.20.1