From b3d58eaffb98e1b5bbf2d6756c59398213caba57 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Wed, 27 Apr 2016 15:47:45 -0400 Subject: [PATCH] atomic_open(): be paranoid about may_open() return value It should never return positives; however, with Linux S&M crowd involved, no bogosity is impossible. Results would be unpleasant... Signed-off-by: Al Viro --- fs/namei.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/namei.c b/fs/namei.c index 3951cc4f34c5..8d562a7a7e01 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2920,6 +2920,8 @@ static int atomic_open(struct nameidata *nd, struct dentry *dentry, acc_mode = 0; } error = may_open(&file->f_path, acc_mode, open_flag); + if (WARN_ON(error > 0)) + error = -EINVAL; out: dput(dentry); return error; -- 2.20.1