From b21a3bf4418899bcb74cbef2e4d3bb976a6f1157 Mon Sep 17 00:00:00 2001 From: Paul Taysom Date: Fri, 9 May 2014 15:06:28 +0900 Subject: [PATCH] drm/exynos: check for null pointers in error handling Smatch error from arm build: drivers/gpu/drm/exynos/ exynos_hdmi.c:2374 hdmi_probe() error: potential NULL dereference 'hdata->hdmiphy_port'. Added check for hdata->hdmiphy_port that it is not NULL. Signed-off-by: Paul Taysom Signed-off-by: Rahul Sharma Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 73a7acb1283c..0dc9e3c9d103 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2174,7 +2174,8 @@ static int hdmi_probe(struct platform_device *pdev) return exynos_drm_component_add(&pdev->dev, &hdmi_component_ops); err_hdmiphy: - put_device(&hdata->hdmiphy_port->dev); + if (hdata->hdmiphy_port) + put_device(&hdata->hdmiphy_port->dev); err_ddc: put_device(&hdata->ddc_adpt->dev); return ret; -- 2.20.1