From a6ce202ead8c834913d068fd65cf29891478acde Mon Sep 17 00:00:00 2001 From: Paul Burton Date: Wed, 15 Jan 2014 10:31:59 +0000 Subject: [PATCH] MIPS: MIPS_CMP should depend upon !SMTC, not upon SMVP Commit f55afb0969cc "MIPS: Clean up MIPS MT and CMP configuration options." introduced a dependency upon MIPS_MT_SMP (ie. SMVP) for the MIPS_CMP (ie. CMP framework support) Kconfig option. It did not specify why, and that dependency is bogus. It is perfectly valid to have a multi-core system with the YAMON bootloader but without MT support - an example of this would be any multi-core proAptiv bitstream running on a Malta. Forcing MT support to be enabled in a kernel for such a system is incorrect. I suspect that the dependency was actually meant to reflect the fact that YAMON will only bind 1 TC per VPE on an MT system, and only describe those 1:1 TC:VPE pairs as CPUs through the AMON interface. Thus an SMTC kernel makes little sense on a system using MIPS_CMP, and the Kconfig dependencies should reflect that rather than introducing the bogus SMVP dependency. Signed-off-by: Paul Burton Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/6368/ Signed-off-by: Ralf Baechle --- arch/mips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index bc681f0889f5..d0b446e154d5 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -2000,7 +2000,7 @@ config MIPS_VPE_APSP_API_MT config MIPS_CMP bool "MIPS CMP framework support" - depends on SYS_SUPPORTS_MIPS_CMP && MIPS_MT_SMP + depends on SYS_SUPPORTS_MIPS_CMP && !MIPS_MT_SMTC select MIPS_GIC_IPI select SYNC_R4K select WEAK_ORDERING -- 2.20.1