From a3f99f8ba8cbd2d4e231b767b3d6236a555da38c Mon Sep 17 00:00:00 2001 From: Akinobu Mita Date: Fri, 29 Dec 2006 16:48:20 -0800 Subject: [PATCH] [PATCH] module: fix mod_sysfs_setup() return value mod_sysfs_setup() doesn't return error when kobject_add_dir() failed. Signed-off-by: Akinobu Mita Cc: Greg KH Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- kernel/module.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/module.c b/kernel/module.c index b565eaeff7e..dbce132b354 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -1132,8 +1132,10 @@ static int mod_sysfs_setup(struct module *mod, goto out; mod->drivers_dir = kobject_add_dir(&mod->mkobj.kobj, "drivers"); - if (!mod->drivers_dir) + if (!mod->drivers_dir) { + err = -ENOMEM; goto out_unreg; + } err = module_param_sysfs_setup(mod, kparam, num_params); if (err) -- 2.20.1