From a269a731396a8f7f3af3064f072b11c09704811a Mon Sep 17 00:00:00 2001 From: Matthias Schmidt Date: Fri, 27 Sep 2019 17:00:35 +0200 Subject: [PATCH] Resolve TODOs related to `wcf1_reaction_type` table --- wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php b/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php index 6884f7afb9..f4cef76852 100644 --- a/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php +++ b/wcfsetup/install/files/acp/update-com.woltlab.wcf_5.2.php @@ -149,12 +149,11 @@ $tables = [ DatabaseTable::create('wcf1_reaction_type') ->columns([ ObjectIdDatabaseTableColumn::create('reactionTypeID'), - // TODO: is currently not `not null` NotNullVarchar255DatabaseTableColumn::create('title'), NotNullInt10DatabaseTableColumn::create('showOrder') ->defaultValue(0), - // TODO: should be varchar - MediumtextDatabaseTableColumn::create('iconFile'), + NotNullVarchar255DatabaseTableColumn::create('iconFile') + ->defaultValue(''), DefaultFalseBooleanDatabaseTableColumn::create('isDisabled') ]) ->indices([ -- 2.20.1