From 99fef1d5d4ddd10f7edb42b5c860535e3b4e0f58 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Joshua=20R=C3=BCsweg?= <josh@bastelstu.be>
Date: Mon, 6 Aug 2018 11:58:51 +0200
Subject: [PATCH] Resolve TODO comments See #2508

---
 .../install/files/lib/system/reaction/ReactionHandler.class.php | 2 --
 wcfsetup/install/lang/de.xml                                    | 1 -
 wcfsetup/install/lang/en.xml                                    | 1 -
 3 files changed, 4 deletions(-)

diff --git a/wcfsetup/install/files/lib/system/reaction/ReactionHandler.class.php b/wcfsetup/install/files/lib/system/reaction/ReactionHandler.class.php
index a21caa378c..3f2326c6d0 100644
--- a/wcfsetup/install/files/lib/system/reaction/ReactionHandler.class.php
+++ b/wcfsetup/install/files/lib/system/reaction/ReactionHandler.class.php
@@ -337,7 +337,6 @@ class ReactionHandler extends SingletonFactory {
 			WCF::getDB()->rollBackTransaction();
 		}
 		
-		// @TODO return some dummy values
 		return [
 			'cachedReactions' => [], 
 		]; 
@@ -537,7 +536,6 @@ class ReactionHandler extends SingletonFactory {
 			WCF::getDB()->rollBackTransaction();
 		}
 		
-		// @TODO return some dummy values
 		return [
 			'cachedReactions' => [],
 			'reactionTypeID' => null,
diff --git a/wcfsetup/install/lang/de.xml b/wcfsetup/install/lang/de.xml
index 8b485d90d7..f51ec5ec2e 100644
--- a/wcfsetup/install/lang/de.xml
+++ b/wcfsetup/install/lang/de.xml
@@ -957,7 +957,6 @@
 		<item name="wcf.acp.menu.link.devtools.notificationTest"><![CDATA[Benachrichtigungstest]]></item>
 		<item name="wcf.acp.menu.link.log.modification"><![CDATA[Globales Veränderungsprotokoll]]></item>
 		<item name="wcf.acp.menu.link.reactionType"><![CDATA[Reaktionen]]></item>
-		<!-- @TODO maybe use "Reaktion" instead of "Reaktions-Typ", because its more comprehensible for users -->
 		<item name="wcf.acp.menu.link.reactionType.list"><![CDATA[Reaktions-Typen]]></item>
 		<item name="wcf.acp.menu.link.reactionType.add"><![CDATA[Reaktions-Typ hinzufügen]]></item>
 		<item name="wcf.acp.menu.link.reactionType.edit"><![CDATA[Reaktions-Typ bearbeiten]]></item>
diff --git a/wcfsetup/install/lang/en.xml b/wcfsetup/install/lang/en.xml
index cc86d6683f..6ece2d81dc 100644
--- a/wcfsetup/install/lang/en.xml
+++ b/wcfsetup/install/lang/en.xml
@@ -939,7 +939,6 @@
 		<item name="wcf.acp.menu.link.devtools.notificationTest"><![CDATA[Notification Test]]></item>
 		<item name="wcf.acp.menu.link.log.modification"><![CDATA[Global Modification Log]]></item>
 		<item name="wcf.acp.menu.link.reactionType"><![CDATA[Reaction]]></item>
-		<!-- @TODO maybe use "Reactions" instead of "Reaction Types", because its more comprehensible for users -->
 		<item name="wcf.acp.menu.link.reactionType.list"><![CDATA[Reaction Types]]></item>
 		<item name="wcf.acp.menu.link.reactionType.add"><![CDATA[Add Reaction Type]]></item>
 		<item name="wcf.acp.menu.link.reactionType.edit"><![CDATA[Edit Reaction Type]]></item>
-- 
2.20.1