From 95d803b7786c787ac0725b4bb227fd0684befa01 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Wed, 22 Jul 2020 15:03:58 +0200
Subject: [PATCH] Use modern UploadHandler to update style favicon

---
 .../install/files/acp/templates/styleAdd.tpl  |  48 ++--
 .../files/images/favicon/corsProxy.php        |  11 +-
 .../Core/Acp/Ui/Style/Favicon/Upload.js       |  59 -----
 .../files/lib/acp/form/StyleAddForm.class.php |  43 +++-
 .../lib/acp/form/StyleEditForm.class.php      |  12 +
 .../files/lib/data/style/Style.class.php      |   8 +-
 .../lib/data/style/StyleAction.class.php      | 217 ++++++------------
 7 files changed, 163 insertions(+), 235 deletions(-)
 delete mode 100644 wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload.js

diff --git a/wcfsetup/install/files/acp/templates/styleAdd.tpl b/wcfsetup/install/files/acp/templates/styleAdd.tpl
index 4bfd920cd3..8fd207f570 100644
--- a/wcfsetup/install/files/acp/templates/styleAdd.tpl
+++ b/wcfsetup/install/files/acp/templates/styleAdd.tpl
@@ -6,10 +6,8 @@
 {js application='wcf' file='WCF.ColorPicker' bundle='WCF.Combined'}
 <script data-relocate="true">
 	require([
-		'WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload',
 		'WoltLabSuite/Core/Acp/Ui/Style/Editor', 'WoltLabSuite/Core/Ui/Toggle/Input', 'Language'
 	], function(
-		AcpUiStyleFaviconUpload,
 		AcpUiStyleEditor, UiToggleInput, Language
 	) {
 		AcpUiStyleEditor.setup({
@@ -21,10 +19,6 @@
 		new UiToggleInput('input[name="useGoogleFont"]', {
 			show: ['#wcfFontFamilyGoogleContainer']
 		});
-		
-		{if $action === 'edit'}
-			new AcpUiStyleFaviconUpload({@$style->styleID});
-		{/if}
 	});
 	
 	$(function() {
@@ -35,8 +29,6 @@
 			'wcf.style.colorPicker.new': '{lang}wcf.style.colorPicker.new{/lang}',
 			'wcf.style.colorPicker.current': '{lang}wcf.style.colorPicker.current{/lang}',
 			'wcf.style.colorPicker.button.apply': '{lang}wcf.style.colorPicker.button.apply{/lang}',
-			'wcf.acp.style.favicon.error.dimensions': '{lang}wcf.acp.style.favicon.error.dimensions{/lang}',
-			'wcf.acp.style.favicon.error.invalidExtension': '{lang}wcf.acp.style.favicon.error.invalidExtension{/lang}',
 			'wcf.acp.style.image.error.invalidExtension': '{lang}wcf.acp.style.image.error.invalidExtension{/lang}'
 		});
 		
@@ -288,25 +280,29 @@
 				{event name='fileFields'}
 			</section>
 			
-			{if $action === 'edit'}
-				<section class="section">
-					<h2 class="sectionTitle">{lang}wcf.acp.style.general.favicon{/lang}</h2>
-					
-					<dl>
-						<dt><label for="favicon">{lang}wcf.acp.style.favicon{/lang}</label></dt>
-						<dd>
-							<div class="selectedFaviconPreview">
-								<img src="{@$style->getFaviconAppleTouchIcon()}" alt="" id="faviconImage" style="height: 32px; width: 32px;">
-							</div>
-							<div id="uploadFavicon"></div>
-							<small>{lang}wcf.acp.style.favicon.description{/lang}</small>
-						</dd>
-					</dl>
-					
-					{event name='faviconFields'}
-				</section>
-			{/if}
+			<section class="section">
+				<h2 class="sectionTitle">{lang}wcf.acp.style.general.favicon{/lang}</h2>
+				
+				<dl{if $errorField == 'image'} class="formError"{/if}>
+					<dt><label for="favicon">{lang}wcf.acp.style.favicon{/lang}</label></dt>
+					<dd>
+						{@$__wcf->getUploadHandler()->renderField('favicon')}
+						{if $errorField == 'favicon'}
+							<small class="innerError">
+								{if $errorType == 'empty'}
+									{lang}wcf.global.form.error.empty{/lang}
+								{else}
+									{lang}wcf.acp.style.favicon.error.{$errorType}{/lang}
+								{/if}
+							</small>
+						{/if}
+						<small>{lang}wcf.acp.style.favicon.description{/lang}</small>
+					</dd>
+				</dl>
 				
+				{event name='faviconFields'}
+			</section>
+			
 			<section class="section">
 				<header class="sectionHeader">
 					<h2 class="sectionTitle">{lang}wcf.acp.style.general.coverPhoto{/lang}</h2>
diff --git a/wcfsetup/install/files/images/favicon/corsProxy.php b/wcfsetup/install/files/images/favicon/corsProxy.php
index 94550bf66d..cbd0c70c47 100644
--- a/wcfsetup/install/files/images/favicon/corsProxy.php
+++ b/wcfsetup/install/files/images/favicon/corsProxy.php
@@ -17,7 +17,12 @@ if (!empty($_GET['type']) || !isset($types[$_GET['type']])) {
 	$type = $_GET['type'];
 	$styleID = (!empty($_GET['styleID'])) ? intval($_GET['styleID']) : 'default';
 	if ($styleID === 'default' || $styleID > 0) {
-		$filename = $styleID . '.' . $types[$type]['filename'];
+		if ($styleID === 'default') {
+			$filename = 'default.' . $types[$type]['filename'];
+		}
+		else {
+			$filename = '../style-'.$styleID.'/'.$types[$type]['filename'];
+		}
 		if (file_exists($filename)) {
 			$filemtime = filemtime($filename);
 			
@@ -34,6 +39,10 @@ if (!empty($_GET['type']) || !isset($types[$_GET['type']])) {
 			
 			$data = file_get_contents($filename);
 			
+			if ($styleID !== 'default') {
+				$data = str_replace('src": "', 'src": "../style-'.$styleID."/", $data);
+			}
+			
 			// send cache and type headers
 			// allow font fetching from all domains (CORS)
 			header('Access-Control-Allow-Origin: *');
diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload.js
deleted file mode 100644
index 51779b7d2d..0000000000
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload.js
+++ /dev/null
@@ -1,59 +0,0 @@
-/**
- * Handles uploading the style favicon.
- * 
- * @author	Alexander Ebert
- * @copyright	2001-2019 WoltLab GmbH
- * @license	GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
- * @module	WoltLabSuite/Core/Acp/Ui/Style/Favicon/Upload
- */
-define(['Core', 'Dom/Traverse', 'Language', 'Ui/Notification', 'Upload'], function(Core, DomTraverse, Language, UiNotification, Upload) {
-	"use strict";
-	
-	/**
-	 * @constructor
-	 */
-	function AcpUiStyleImageUpload(styleId) {
-		this._styleId = ~~styleId;
-		
-		Upload.call(this, 'uploadFavicon', 'faviconImage', {
-			action: 'uploadFavicon',
-			className: 'wcf\\data\\style\\StyleAction'
-		});
-	}
-	Core.inherit(AcpUiStyleImageUpload, Upload, {
-		/**
-		 * @see	WoltLabSuite/Core/Upload#_createFileElement
-		 */
-		_createFileElement: function(file) {
-			return this._target;
-		},
-		
-		/**
-		 * @see	WoltLabSuite/Core/Upload#_getParameters
-		 */
-		_getParameters: function() {
-			return {
-				styleID: this._styleId
-			};
-		},
-		
-		/**
-		 * @see	WoltLabSuite/Core/Upload#_success
-		 */
-		_success: function(uploadId, data) {
-			var errorMessage = '';
-			if (data.returnValues.url) {
-				elAttr(this._target, 'src', data.returnValues.url + '?timestamp=' + Date.now());
-				
-				UiNotification.show();
-			}
-			else if (data.returnValues.errorType) {
-				errorMessage = Language.get('wcf.acp.style.favicon.error.' + data.returnValues.errorType);
-			}
-			
-			elInnerError(this._button, errorMessage);
-		}
-	});
-	
-	return AcpUiStyleImageUpload;
-});
diff --git a/wcfsetup/install/files/lib/acp/form/StyleAddForm.class.php b/wcfsetup/install/files/lib/acp/form/StyleAddForm.class.php
index 2ea4e70b42..3794989171 100644
--- a/wcfsetup/install/files/lib/acp/form/StyleAddForm.class.php
+++ b/wcfsetup/install/files/lib/acp/form/StyleAddForm.class.php
@@ -278,6 +278,14 @@ class StyleAddForm extends AbstractForm {
 		$field->setImageOnly(true);
 		$field->maxFiles = 1;
 		$handler->registerUploadField($field);
+		
+		if ($handler->isRegisteredFieldId('favicon')) {
+			$handler->unregisterUploadField('favicon');
+		}
+		$field = new UploadField('favicon');
+		$field->setImageOnly(true);
+		$field->maxFiles = 1;
+		$handler->registerUploadField($field);
 	}
 	
 	/**
@@ -343,7 +351,7 @@ class StyleAddForm extends AbstractForm {
 		if (isset($_POST['scrollOffsets']) && is_array($_POST['scrollOffsets'])) $this->scrollOffsets = ArrayUtil::toIntegerArray($_POST['scrollOffsets']); 
 		
 		$this->uploads = [];
-		foreach (['image', 'image2x', 'pageLogo', 'pageLogoMobile', 'coverPhoto'] as $field) {
+		foreach (['image', 'image2x', 'pageLogo', 'pageLogoMobile', 'coverPhoto', 'favicon'] as $field) {
 			$removedFiles = UploadHandler::getInstance()->getRemovedFiledByFieldId($field);
 			if (!empty($removedFiles)) {
 				$this->uploads[$field] = null;
@@ -535,10 +543,39 @@ class StyleAddForm extends AbstractForm {
 			}
 			
 			if ($imageData[0] < UserCoverPhoto::MIN_WIDTH) {
-				throw new UserInputException('coverPhoto', 'minWidth');
+				throw new UserInputException($field, 'minWidth');
 			}
 			if ($imageData[1] < UserCoverPhoto::MIN_HEIGHT) {
-				throw new UserInputException('coverPhoto', 'minHeight');
+				throw new UserInputException($field, 'minHeight');
+			}
+		}
+		
+		// favicon
+		$field = 'favicon';
+		$files = UploadHandler::getInstance()->getFilesByFieldId($field);
+		if (count($files) > 1) {
+			throw new UserInputException($field, 'invalid');
+		}
+		if (!empty($files)) {
+			$fileLocation = $files[0]->getLocation();
+			if (($imageData = getimagesize($fileLocation)) === false) {
+				throw new UserInputException($field, 'invalid');
+			}
+			switch ($imageData[2]) {
+				case IMAGETYPE_PNG:
+				case IMAGETYPE_JPEG:
+				case IMAGETYPE_GIF:
+					// fine
+				break;
+				default:
+					throw new UserInputException($field, 'invalid');
+			}
+			
+			if ($imageData[0] != Style::FAVICON_IMAGE_WIDTH) {
+				throw new UserInputException($field, 'dimensions');
+			}
+			if ($imageData[1] != Style::FAVICON_IMAGE_HEIGHT) {
+				throw new UserInputException($field, 'dimensions');
 			}
 		}
 	}
diff --git a/wcfsetup/install/files/lib/acp/form/StyleEditForm.class.php b/wcfsetup/install/files/lib/acp/form/StyleEditForm.class.php
index 18c78ac908..9bf83bd51a 100644
--- a/wcfsetup/install/files/lib/acp/form/StyleEditForm.class.php
+++ b/wcfsetup/install/files/lib/acp/form/StyleEditForm.class.php
@@ -170,6 +170,18 @@ class StyleEditForm extends StyleAddForm {
 					$file,
 				]);
 			}
+			if ($this->style->hasFavicon) {
+				foreach (['png', 'jpg', 'gif'] as $extension) {
+					if (file_exists($this->style->getAssetPath()."favicon.template.".$extension)) {
+						$file = new UploadFile($this->style->getAssetPath()."favicon.template.".$extension, "favicon.template.".$extension, true, true, false);
+						UploadHandler::getInstance()->registerFilesByField('favicon', [
+							$file,
+						]);
+						break;
+					}
+				}
+				
+			}
 		}
 	}
 	
diff --git a/wcfsetup/install/files/lib/data/style/Style.class.php b/wcfsetup/install/files/lib/data/style/Style.class.php
index fefd733267..32842dece8 100644
--- a/wcfsetup/install/files/lib/data/style/Style.class.php
+++ b/wcfsetup/install/files/lib/data/style/Style.class.php
@@ -273,7 +273,13 @@ class Style extends DatabaseObject {
 			}
 		}
 		
-		$path = 'images/favicon/'. ($this->hasFavicon ? $this->styleID : 'default') . ".{$filename}";
+		if ($this->hasFavicon) {
+			$path = FileUtil::getRelativePath(WCF_DIR, $this->getAssetPath()).$filename;
+		}
+		else {
+			$path = 'images/favicon/default.'.$filename;
+		}
+		
 		if ($absolutePath) {
 			return WCF::getPath() . $path;
 		}
diff --git a/wcfsetup/install/files/lib/data/style/StyleAction.class.php b/wcfsetup/install/files/lib/data/style/StyleAction.class.php
index 4a4b61f279..24225d20f6 100644
--- a/wcfsetup/install/files/lib/data/style/StyleAction.class.php
+++ b/wcfsetup/install/files/lib/data/style/StyleAction.class.php
@@ -86,6 +86,9 @@ class StyleAction extends AbstractDatabaseObjectAction implements IToggleAction
 		// handle style preview image
 		$this->updateStylePreviewImage($style);
 		
+		// create favicon data
+		$this->updateFavicons($style);
+		
 		// handle the cover photo
 		$this->updateCoverPhoto($style);
 
@@ -295,37 +298,71 @@ class StyleAction extends AbstractDatabaseObjectAction implements IToggleAction
 	 * @since       3.1
 	 */
 	protected function updateFavicons(Style $style) {
-		$styleID = $style->styleID;
-		$fileExtension = WCF::getSession()->getVar('styleFavicon-template-'.$styleID);
-		$hasFavicon = (bool)$style->hasFavicon;
-		if ($fileExtension) {
-			$template = WCF_DIR . "images/favicon/{$styleID}.favicon-template.{$fileExtension}";
-			$images = [
-				'android-chrome-192x192.png' => 192,
-				'android-chrome-256x256.png' => 256,
-				'apple-touch-icon.png' => 180,
-				'mstile-150x150.png' => 150
-			];
+		$images = [
+			'android-chrome-192x192.png' => 192,
+			'android-chrome-256x256.png' => 256,
+			'apple-touch-icon.png' => 180,
+			'mstile-150x150.png' => 150
+		];
+		
+		$hasFavicon = $style->hasFavicon;
+		if (array_key_exists('favicon', $this->parameters['uploads'])) {
+			/** @var \wcf\system\file\upload\UploadFile $file */
+			$file = $this->parameters['uploads']['favicon'];
 			
-			$adapter = ImageHandler::getInstance()->getAdapter();
-			$adapter->loadFile($template);
-			foreach ($images as $filename => $length) {
-				$thumbnail = $adapter->createThumbnail($length, $length);
-				$adapter->writeImage($thumbnail, WCF_DIR."images/favicon/{$styleID}.{$filename}");
+			if ($style->coverPhotoExtension && file_exists($style->getCoverPhotoLocation())) {
+				if (!$file || $style->getCoverPhotoLocation() !== $file->getLocation()) {
+					unlink($style->getCoverPhotoLocation());
+				}
+			}
+			if ($file !== null) {
+				$fileLocation = $file->getLocation();
+				if (($imageData = getimagesize($fileLocation)) === false) {
+					throw new \InvalidArgumentException('The given favicon is not an image');
+				}
+				$extension = ImageUtil::getExtensionByMimeType($imageData['mime']);
+				$newName = "favicon.template.".$extension;
+				$newLocation = $style->getAssetPath().$newName;
+				rename($fileLocation, $newLocation);
+				
+				// Create browser specific files.
+				$adapter = ImageHandler::getInstance()->getAdapter();
+				$adapter->loadFile($newLocation);
+				foreach ($images as $filename => $length) {
+					$thumbnail = $adapter->createThumbnail($length, $length);
+					$adapter->writeImage($thumbnail, $style->getAssetPath().$filename);
+				}
+				
+				// Create ICO file.
+				require(WCF_DIR . 'lib/system/api/chrisjean/php-ico/class-php-ico.php');
+				(new \PHP_ICO($newLocation, [
+					[16, 16],
+					[32, 32]
+				]))->save_ico($style->getAssetPath()."favicon.ico");
+				
+				(new StyleEditor($style))->update([
+					'hasFavicon' => 1,
+				]);
+				
+				$file->setProcessed($newLocation);
+				$hasFavicon = true;
+			}
+			else {
+				foreach ($images as $filename => $length) {
+					unlink($style->getAssetPath().$filename);
+				}
+				unlink($style->getAssetPath()."favicon.ico");
+				foreach (['png', 'jpg', 'gif'] as $extension) {
+					if (file_exists($style->getAssetPath()."favicon.template.".$extension)) {
+						unlink($style->getAssetPath()."favicon.template.".$extension);
+					}
+				}
+				(new StyleEditor($style))->update([
+					'hasFavicon' => 0,
+				]);
+				
+				$hasFavicon = false;
 			}
-			
-			// create ico
-			require(WCF_DIR . 'lib/system/api/chrisjean/php-ico/class-php-ico.php');
-			$phpIco = new \PHP_ICO($template, [
-				[16, 16],
-				[32, 32]
-			]);
-			$phpIco->save_ico(WCF_DIR . "images/favicon/{$styleID}.favicon.ico");
-			
-			$hasFavicon = true;
-			
-			(new StyleEditor($style))->update(['hasFavicon' => 1]);
-			WCF::getSession()->unregister('styleFavicon-template-'.$style->styleID);
 		}
 		
 		if ($hasFavicon) {
@@ -335,12 +372,12 @@ class StyleAction extends AbstractDatabaseObjectAction implements IToggleAction
     "name": "",
     "icons": [
         {
-            "src": "{$styleID}.android-chrome-192x192.png",
+            "src": "android-chrome-192x192.png",
             "sizes": "192x192",
             "type": "image/png"
         },
         {
-            "src": "{$styleID}.android-chrome-256x256.png",
+            "src": "android-chrome-256x256.png",
             "sizes": "256x256",
             "type": "image/png"
         }
@@ -350,7 +387,7 @@ class StyleAction extends AbstractDatabaseObjectAction implements IToggleAction
     "display": "standalone"
 }
 MANIFEST;
-			file_put_contents(WCF_DIR . "images/favicon/{$styleID}.manifest.json", $manifest);
+			file_put_contents($style->getAssetPath()."manifest.json", $manifest);
 			
 			$style->loadVariables();
 			$tileColor = $style->getVariable('wcfHeaderBackground', true);
@@ -361,13 +398,13 @@ MANIFEST;
 <browserconfig>
     <msapplication>
         <tile>
-            <square150x150logo src="{$styleID}.mstile-150x150.png"/>
+            <square150x150logo src="mstile-150x150.png"/>
             <TileColor>{$tileColor}</TileColor>
         </tile>
     </msapplication>
 </browserconfig>
 BROWSERCONFIG;
-			file_put_contents(WCF_DIR . "images/favicon/{$styleID}.browserconfig.xml", $browserconfig);
+			file_put_contents($style->getAssetPath()."browserconfig.xml", $browserconfig);
 		}
 	}
 	
@@ -378,8 +415,6 @@ BROWSERCONFIG;
 	 * @since       3.1
 	 */
 	protected function updateCoverPhoto(Style $style) {
-		$type = 'coverPhoto';
-		
 		if (array_key_exists('coverPhoto', $this->parameters['uploads'])) {
 			/** @var \wcf\system\file\upload\UploadFile $file */
 			$file = $this->parameters['uploads']['coverPhoto'];
@@ -392,7 +427,7 @@ BROWSERCONFIG;
 			if ($file !== null) {
 				$fileLocation = $file->getLocation();
 				if (($imageData = getimagesize($fileLocation)) === false) {
-					throw new \InvalidArgumentException('The given '.$type.' is not an image');
+					throw new \InvalidArgumentException('The given coverPhoto is not an image');
 				}
 				$extension = ImageUtil::getExtensionByMimeType($imageData['mime']);
 				$newLocation = $style->getAssetPath().'coverPhoto.'.$extension;
@@ -411,114 +446,6 @@ BROWSERCONFIG;
 		}
 	}
 	
-	/**
-	 * @inheritDoc
-	 */
-	public function validateUpload() {
-		// check upload permissions
-		if (!WCF::getSession()->getPermission('admin.style.canManageStyle')) {
-			throw new PermissionDeniedException();
-		}
-		
-		$this->readBoolean('is2x', true);
-		$this->readString('tmpHash');
-		$this->readInteger('styleID', true);
-		
-		if ($this->parameters['styleID']) {
-			$styles = StyleHandler::getInstance()->getStyles();
-			if (!isset($styles[$this->parameters['styleID']])) {
-				throw new UserInputException('styleID');
-			}
-			
-			$this->style = $styles[$this->parameters['styleID']];
-		}
-		
-		/** @var UploadHandler $uploadHandler */
-		$uploadHandler = $this->parameters['__files'];
-		
-		if (count($uploadHandler->getFiles()) != 1) {
-			throw new IllegalLinkException();
-		}
-		
-		// check max filesize, allowed file extensions etc.
-		$uploadHandler->validateFiles(new DefaultUploadFileValidationStrategy(PHP_INT_MAX, ['jpg', 'jpeg', 'png', 'gif', 'svg']));
-	}
-	
-	/**
-	 * Validates parameters to upload a favicon.
-	 * 
-	 * @since       3.1
-	 */
-	public function validateUploadFavicon() {
-		// ignore tmp hash, uploading is supported for existing styles only
-		// and files will be finally processed on form submit
-		$this->parameters['tmpHash'] = '@@@WCF_INVALID_TMP_HASH@@@';
-		
-		$this->validateUpload();
-	}
-	
-	/**
-	 * Handles favicon upload.
-	 *
-	 * @return	string[]
-	 * @since       3.1
-	 */
-	public function uploadFavicon() {
-		// save files
-		/** @noinspection PhpUndefinedMethodInspection */
-		/** @var UploadFile[] $files */
-		$files = $this->parameters['__files']->getFiles();
-		$file = $files[0];
-		
-		try {
-			if (!$file->getValidationErrorType()) {
-				$fileLocation = $file->getLocation();
-				try {
-					if (($imageData = getimagesize($fileLocation)) === false) {
-						throw new UserInputException('favicon');
-					}
-					switch ($imageData[2]) {
-						case IMAGETYPE_PNG:
-						case IMAGETYPE_JPEG:
-						case IMAGETYPE_GIF:
-							// fine
-							break;
-						default:
-							throw new UserInputException('favicon');
-					}
-					
-					if ($imageData[0] != Style::FAVICON_IMAGE_WIDTH || $imageData[1] != Style::FAVICON_IMAGE_HEIGHT) {
-						throw new UserInputException('favicon', 'dimensions');
-					}
-				}
-				catch (SystemException $e) {
-					throw new UserInputException('favicon');
-				}
-				
-				// move uploaded file
-				if (@copy($fileLocation, WCF_DIR.'images/favicon/'.$this->style->styleID.'.favicon-template.'.$file->getFileExtension())) {
-					@unlink($fileLocation);
-					
-					// store extension within session variables
-					WCF::getSession()->register('styleFavicon-template-'.$this->style->styleID, $file->getFileExtension());
-					
-					// return result
-					return [
-						'url' => WCF::getPath().'images/favicon/'.$this->style->styleID.'.favicon-template.'.$file->getFileExtension()
-					];
-				}
-				else {
-					throw new UserInputException('favicon', 'uploadFailed');
-				}
-			}
-		}
-		catch (UserInputException $e) {
-			$file->setValidationErrorType($e->getType());
-		}
-		
-		return ['errorType' => $file->getValidationErrorType()];
-	}
-	
 	/**
 	 * Validates parameters to assign a new default style.
 	 */
-- 
2.20.1