From 8e8db7f123dcc4d56464fc584667c8f9ae9f4aef Mon Sep 17 00:00:00 2001 From: David Henningsson Date: Fri, 18 Jan 2013 15:43:02 +0100 Subject: [PATCH] ALSA: hda - don't compare with yourself in fill_input_pin_labels Just stumbled over this one while reading the code. Signed-off-by: David Henningsson Signed-off-by: Takashi Iwai --- sound/pci/hda/hda_generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 10b14a925ddb..e4e71fa8d87c 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -2558,7 +2558,7 @@ static int fill_input_pin_labels(struct hda_codec *codec) label = hda_get_autocfg_input_label(codec, cfg, i); idx = 0; - for (j = i; j >= 0; j--) { + for (j = i - 1; j >= 0; j--) { if (spec->input_labels[j] && !strcmp(spec->input_labels[j], label)) { idx = spec->input_label_idxs[j] + 1; -- 2.20.1