From 875395739afb40b58019315591fab05a5ea0ea90 Mon Sep 17 00:00:00 2001 From: Olaf Braun Date: Wed, 3 Jul 2024 14:08:18 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Alexander Ebert --- .../Core/Form/Builder/Field/Controller/FileProcessor.ts | 3 ++- .../files/lib/system/file/processor/FileProcessor.class.php | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts index b4fd565ca6..291a68fbab 100644 --- a/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts +++ b/ts/WoltLabSuite/Core/Form/Builder/Field/Controller/FileProcessor.ts @@ -17,7 +17,8 @@ import { } from "WoltLabSuite/Core/Component/File/File"; import { clearPreviousErrors } from "WoltLabSuite/Core/Component/File/Upload"; -const _data = new Map(); +type FileId = string; +const fileProcessors = new Map(); export interface ExtraButton { title: string; diff --git a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php index d770ef4ff8..d38534d8b9 100644 --- a/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php +++ b/wcfsetup/install/files/lib/system/file/processor/FileProcessor.class.php @@ -240,8 +240,8 @@ final class FileProcessor extends SingletonFactory public function hasReachedUploadLimit(IFileProcessor $fileProcessor, array $context): bool { - // Replace button from `FileProcessorFormField` is clicked. - if (!empty($context["__replace"])) { + $isReplacement = $context['__replace'] ?? false; + if ($isReplacement) { return false; } -- 2.20.1