From 871e7c01ca55fdc714691206f041e48f695f444c Mon Sep 17 00:00:00 2001 From: Christophe Jaillet Date: Sun, 6 Aug 2017 14:55:01 +0200 Subject: [PATCH] mtd: physmap_of: Fix resources leak in 'of_flash_probe()' If 'of_flash_probe_gemini()' or 'of_flash_probe_versatile()' fail, we must reslease some resources, as already done in all error handling paths in this function. Signed-off-by: Christophe JAILLET Signed-off-by: Boris Brezillon --- drivers/mtd/maps/physmap_of_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/maps/physmap_of_core.c b/drivers/mtd/maps/physmap_of_core.c index 1343c34092ca..b1bd4faecfb2 100644 --- a/drivers/mtd/maps/physmap_of_core.c +++ b/drivers/mtd/maps/physmap_of_core.c @@ -235,10 +235,10 @@ static int of_flash_probe(struct platform_device *dev) err = of_flash_probe_gemini(dev, dp, &info->list[i].map); if (err) - return err; + goto err_out; err = of_flash_probe_versatile(dev, dp, &info->list[i].map); if (err) - return err; + goto err_out; err = -ENOMEM; info->list[i].map.virt = ioremap(info->list[i].map.phys, -- 2.20.1