From 86b5ac878d4a63c772d03c5017b72cc799a8f2f2 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Mon, 18 Apr 2005 21:16:58 -0700 Subject: [PATCH] [PATCH] I2C: via686a cleanups Here comes a small cleanup patch for the via686a driver. I noticed the following two non-fatal problems: 1* The device parent is explicitely set, but it's not needed because the i2c core will do as the client is registered. 2* snprintf is used where strlcpy would suffice. Fixing them brings the via686a driver in line with what other similar drivers do. Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/chips/via686a.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/chips/via686a.c b/drivers/i2c/chips/via686a.c index 9b948f4531f5..ecd1e1de3f05 100644 --- a/drivers/i2c/chips/via686a.c +++ b/drivers/i2c/chips/via686a.c @@ -651,10 +651,9 @@ static int via686a_detect(struct i2c_adapter *adapter, int address, int kind) new_client->adapter = adapter; new_client->driver = &via686a_driver; new_client->flags = 0; - new_client->dev.parent = &adapter->dev; /* Fill in the remaining client fields and put into the global list */ - snprintf(new_client->name, I2C_NAME_SIZE, client_name); + strlcpy(new_client->name, client_name, I2C_NAME_SIZE); data->valid = 0; init_MUTEX(&data->update_lock); -- 2.20.1