From 7a207c8ed3727637ab75524fa0714953cd0b7313 Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Wed, 13 Mar 2019 13:13:27 +0100 Subject: [PATCH] `StringUtil::encodeJS()` was a bit inefficient for large strings --- .../install/files/lib/util/StringUtil.class.php | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/wcfsetup/install/files/lib/util/StringUtil.class.php b/wcfsetup/install/files/lib/util/StringUtil.class.php index a50333d66c..f96a279925 100644 --- a/wcfsetup/install/files/lib/util/StringUtil.class.php +++ b/wcfsetup/install/files/lib/util/StringUtil.class.php @@ -119,20 +119,8 @@ final class StringUtil { * @return string */ public static function encodeJS($string) { - // unify newlines $string = self::unifyNewlines($string); - - // escape backslash - $string = str_replace("\\", "\\\\", $string); - - // escape singe quote - $string = str_replace("'", "\'", $string); - - // escape new lines - $string = str_replace("\n", '\n', $string); - - // escape slashes - $string = str_replace("/", '\/', $string); + $string = str_replace(["\\", "'", "\n", "/"], ["\\\\", "\'", '\n', '\/'], $string); return $string; } -- 2.20.1