From 7902c16b9a5b7001d79940d6b4e99366d6e525d8 Mon Sep 17 00:00:00 2001 From: Paul Zimmerman Date: Mon, 22 Apr 2013 14:00:18 -0700 Subject: [PATCH] staging: dwc2: check for null pointer before dereferencing it We were testing qtd->urb pointer for null after we had already dereferenced it Reported-by: Dan Carpenter Signed-off-by: Paul Zimmerman Signed-off-by: Greg Kroah-Hartman --- drivers/staging/dwc2/hcd_intr.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dwc2/hcd_intr.c b/drivers/staging/dwc2/hcd_intr.c index a8d8c53a8b23..6e5dbed6ccec 100644 --- a/drivers/staging/dwc2/hcd_intr.c +++ b/drivers/staging/dwc2/hcd_intr.c @@ -1377,13 +1377,12 @@ static void dwc2_hc_nyet_intr(struct dwc2_hsotg *hsotg, hsotg->core_params->dma_enable > 0) { qtd->complete_split = 0; qtd->isoc_split_offset = 0; - if (++qtd->isoc_frame_index == qtd->urb->packet_count) { - if (qtd->urb) - dwc2_host_complete(hsotg, - qtd->urb->priv, - qtd->urb, 0); + if (qtd->urb && + ++qtd->isoc_frame_index == qtd->urb->packet_count) { + dwc2_host_complete(hsotg, qtd->urb->priv, + qtd->urb, 0); dwc2_release_channel(hsotg, chan, qtd, - DWC2_HC_XFER_URB_COMPLETE); + DWC2_HC_XFER_URB_COMPLETE); } else { dwc2_release_channel(hsotg, chan, qtd, DWC2_HC_XFER_NO_HALT_STATUS); -- 2.20.1