From 77ac0e53e4c22a2cafeab2cc6a8d40717a44407d Mon Sep 17 00:00:00 2001 From: Matthias Schmidt Date: Sun, 14 Oct 2018 14:49:13 +0200 Subject: [PATCH] Fix code inspection issues See #2545 --- .../pip/DevtoolsPackageInstallationDispatcher.class.php | 1 - .../pip/TMultiXmlGuiPackageInstallationPlugin.class.php | 4 +++- .../plugin/LanguagePackageInstallationPlugin.class.php | 2 +- .../package/plugin/SmileyPackageInstallationPlugin.class.php | 1 + .../UserNotificationEventPackageInstallationPlugin.class.php | 1 - .../plugin/UserProfileMenuPackageInstallationPlugin.class.php | 1 - 6 files changed, 5 insertions(+), 5 deletions(-) diff --git a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationDispatcher.class.php b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationDispatcher.class.php index c06ab37658..61dfcb84be 100644 --- a/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationDispatcher.class.php +++ b/wcfsetup/install/files/lib/system/devtools/pip/DevtoolsPackageInstallationDispatcher.class.php @@ -2,7 +2,6 @@ namespace wcf\system\devtools\pip; use wcf\data\devtools\project\DevtoolsProject; use wcf\system\devtools\package\DevtoolsInstaller; -use wcf\system\devtools\package\DevtoolsPackageArchive; use wcf\system\package\PackageInstallationDispatcher; /** diff --git a/wcfsetup/install/files/lib/system/devtools/pip/TMultiXmlGuiPackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/devtools/pip/TMultiXmlGuiPackageInstallationPlugin.class.php index 4c9a42142b..f324e967a3 100644 --- a/wcfsetup/install/files/lib/system/devtools/pip/TMultiXmlGuiPackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/devtools/pip/TMultiXmlGuiPackageInstallationPlugin.class.php @@ -2,6 +2,7 @@ namespace wcf\system\devtools\pip; use wcf\system\form\builder\field\IFormField; use wcf\system\form\builder\IFormDocument; +use wcf\system\form\builder\IFormNode; use wcf\system\package\PackageInstallationDispatcher; use wcf\util\DOMUtil; use wcf\util\XML; @@ -153,7 +154,8 @@ trait TMultiXmlGuiPackageInstallationPlugin { $data = $this->getElementData($element); - /** @var IFormNode $node */ + /** @var IFormNode $node + */ foreach ($document->getIterator() as $node) { if ($node instanceof IFormField && $node->isAvailable()) { $key = $node->getId(); diff --git a/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php index e422ea05ff..5526b84999 100644 --- a/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/package/plugin/LanguagePackageInstallationPlugin.class.php @@ -613,7 +613,7 @@ class LanguagePackageInstallationPlugin extends AbstractXMLPackageInstallationPl * @return string */ protected function getEmptyXml($languageCode) { - $xsdFilename = $this->getXsdFilenlangame(); + $xsdFilename = $this->getXsdFilename(); $language = LanguageFactory::getInstance()->getLanguageByCode($languageCode); if ($language === null) { diff --git a/wcfsetup/install/files/lib/system/package/plugin/SmileyPackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/SmileyPackageInstallationPlugin.class.php index 3d8605cb4d..551c0210f7 100644 --- a/wcfsetup/install/files/lib/system/package/plugin/SmileyPackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/package/plugin/SmileyPackageInstallationPlugin.class.php @@ -5,6 +5,7 @@ use wcf\data\smiley\SmileyList; use wcf\system\devtools\pip\IDevtoolsPipEntryList; use wcf\system\devtools\pip\IGuiPackageInstallationPlugin; use wcf\system\devtools\pip\TXmlGuiPackageInstallationPlugin; +use wcf\system\form\builder\container\FormContainer; use wcf\system\form\builder\field\IntegerFormField; use wcf\system\form\builder\field\ItemListFormField; use wcf\system\form\builder\field\TextFormField; diff --git a/wcfsetup/install/files/lib/system/package/plugin/UserNotificationEventPackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/UserNotificationEventPackageInstallationPlugin.class.php index 3455c4049a..052d636df5 100644 --- a/wcfsetup/install/files/lib/system/package/plugin/UserNotificationEventPackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/package/plugin/UserNotificationEventPackageInstallationPlugin.class.php @@ -15,7 +15,6 @@ use wcf\system\form\builder\field\validation\FormFieldValidationError; use wcf\system\form\builder\field\validation\FormFieldValidator; use wcf\system\form\builder\field\BooleanFormField; use wcf\system\form\builder\field\ClassNameFormField; -use wcf\system\form\builder\field\ItemListFormField; use wcf\system\form\builder\field\SingleSelectionFormField; use wcf\system\form\builder\field\TextFormField; use wcf\system\form\builder\IFormDocument; diff --git a/wcfsetup/install/files/lib/system/package/plugin/UserProfileMenuPackageInstallationPlugin.class.php b/wcfsetup/install/files/lib/system/package/plugin/UserProfileMenuPackageInstallationPlugin.class.php index fceba3f7cc..d6e6aab1c2 100644 --- a/wcfsetup/install/files/lib/system/package/plugin/UserProfileMenuPackageInstallationPlugin.class.php +++ b/wcfsetup/install/files/lib/system/package/plugin/UserProfileMenuPackageInstallationPlugin.class.php @@ -12,7 +12,6 @@ use wcf\system\form\builder\field\validation\FormFieldValidationError; use wcf\system\form\builder\field\validation\FormFieldValidator; use wcf\system\form\builder\field\ClassNameFormField; use wcf\system\form\builder\field\IntegerFormField; -use wcf\system\form\builder\field\ItemListFormField; use wcf\system\form\builder\field\TextFormField; use wcf\system\form\builder\IFormDocument; use wcf\system\menu\user\profile\content\IUserProfileMenuContent; -- 2.20.1