From 76bbdcb35ebb0e9c5315c4b249cd883cca9e065d Mon Sep 17 00:00:00 2001 From: Sudip Mukherjee Date: Wed, 6 Apr 2016 12:25:39 +0100 Subject: [PATCH] tty: ipwireless: fix possible NULL dereference The function alloc_ctrl_packet() can fail and return NULL. Incase it fails print an error message and exit. Signed-off-by: Sudip Mukherjee Reviewed-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/tty/ipwireless/hardware.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/tty/ipwireless/hardware.c b/drivers/tty/ipwireless/hardware.c index ad7031a4f3c4..df0204b6148f 100644 --- a/drivers/tty/ipwireless/hardware.c +++ b/drivers/tty/ipwireless/hardware.c @@ -1572,6 +1572,11 @@ static void handle_received_SETUP_packet(struct ipw_hardware *hw, sizeof(struct ipw_setup_reboot_msg_ack), ADDR_SETUP_PROT, TL_PROTOCOLID_SETUP, TL_SETUP_SIGNO_REBOOT_MSG_ACK); + if (!packet) { + pr_err(IPWIRELESS_PCCARD_NAME + ": Not enough memory to send reboot packet"); + break; + } packet->header.length = sizeof(struct TlSetupRebootMsgAck); send_packet(hw, PRIO_SETUP, &packet->header); -- 2.20.1