From 7557d0481bdeed86780c073e591df0330ec88a9e Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Mon, 2 May 2016 10:51:49 +0530 Subject: [PATCH] greybus: fw-download: Create a macro for length of firmware file's name Create a macro representing the length of the firmware file's name and use that instead of using magic number in the code. Suggested-by: Greg Kroah-Hartman Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/fw-download.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/fw-download.c b/drivers/staging/greybus/fw-download.c index 836b02b9d7c6..e60abde2d704 100644 --- a/drivers/staging/greybus/fw-download.c +++ b/drivers/staging/greybus/fw-download.c @@ -11,9 +11,12 @@ #include "firmware.h" #include "greybus.h" +/* Length of the string in format: ara_%08x_%08x_%08x_%08x_%s.tftf */ +#define FW_NAME_LEN 56 + struct fw_request { u8 firmware_id; - char name[56]; /* ara_%08x_%08x_%08x_%08x_%s.tftf */ + char name[FW_NAME_LEN]; const struct firmware *fw; struct list_head node; }; -- 2.20.1