From 6ff60d397b172bd89955433bd9e74be4627d7b9e Mon Sep 17 00:00:00 2001 From: Philipp Zabel Date: Wed, 26 Feb 2014 20:41:09 +0100 Subject: [PATCH] of: Warn if of_graph_get_next_endpoint is called with the root node If of_graph_get_next_endpoint is given a parentless node instead of an endpoint node, it is clearly a bug. Signed-off-by: Philipp Zabel Acked-by: Tomi Valkeinen Acked-by: Mauro Carvalho Chehab Acked-by: Sylwester Nawrocki --- drivers/of/base.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index b2f223fa47e9..b5e690bd6e9c 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -2028,8 +2028,8 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent, of_node_put(node); } else { port = of_get_parent(prev); - if (!port) - /* Hm, has someone given us the root node ?... */ + if (WARN_ONCE(!port, "%s(): endpoint %s has no parent node\n", + __func__, prev->full_name)) return NULL; /* Avoid dropping prev node refcount to 0. */ -- 2.20.1