From 6ddbed576606a454353638dbbbcc2f66f0fc712d Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 28 Apr 2016 16:19:39 +0200 Subject: [PATCH] greybus: interface: fix broken UniPro flow control A recent commit inadvertently disabled E2EFC on all interface connections, due to a failure to clear the ES3 bootrom quirk flags during mode switch. Testing Done: Verified that the CPort flags are again set to 0x7 for non-bootrom interface connections. Fixes: 5b638080e94e ("svc: keep interfaces registered during mode switch") Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/greybus/interface.c b/drivers/staging/greybus/interface.c index f6c058a63fa2..b5ad1ac9d3df 100644 --- a/drivers/staging/greybus/interface.c +++ b/drivers/staging/greybus/interface.c @@ -226,6 +226,9 @@ static int gb_interface_read_and_clear_init_status(struct gb_interface *intf) intf->quirks |= GB_INTERFACE_QUIRK_NO_CPORT_FEATURES; intf->quirks |= GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION; break; + default: + intf->quirks &= ~GB_INTERFACE_QUIRK_NO_CPORT_FEATURES; + intf->quirks &= ~GB_INTERFACE_QUIRK_NO_INTERFACE_VERSION; } /* Clear the init status. */ -- 2.20.1