From 652ff672a64b376bb93c186fe5c4489a868c21b7 Mon Sep 17 00:00:00 2001
From: Marcel Werk
Date: Mon, 25 Jan 2016 13:01:23 +0100
Subject: [PATCH] Minor user profile improvements
---
com.woltlab.wcf/templates/user.tpl | 4 +-
com.woltlab.wcf/templates/userSidebar.tpl | 56 +++++++++----------
wcfsetup/install/files/js/WCF.Comment.js | 16 +++---
.../install/files/lib/page/UserPage.class.php | 6 +-
.../files/style/layout/containerList.scss | 3 +-
.../install/files/style/layout/global.scss | 2 +-
6 files changed, 41 insertions(+), 46 deletions(-)
diff --git a/com.woltlab.wcf/templates/user.tpl b/com.woltlab.wcf/templates/user.tpl
index 6e39a70b69..97aeb12313 100644
--- a/com.woltlab.wcf/templates/user.tpl
+++ b/com.woltlab.wcf/templates/user.tpl
@@ -134,9 +134,9 @@
-{include file='userSidebar' assign='sidebar'}
+{include file='userSidebar' assign='sidebarRight'}
-{include file='header' sidebarOrientation='left'}
+{include file='header'}
{include file='userNotice'}
diff --git a/com.woltlab.wcf/templates/userSidebar.tpl b/com.woltlab.wcf/templates/userSidebar.tpl
index 17ac5f44be..75d58e013f 100644
--- a/com.woltlab.wcf/templates/userSidebar.tpl
+++ b/com.woltlab.wcf/templates/userSidebar.tpl
@@ -11,7 +11,7 @@
data-disable-signature="{@$user->disableSignature}"
{/if}
{/if}
->
+>{*todo*}
{/if}
-
+
{if $user->isVisibleOption('gender') && $user->gender}- {lang}wcf.user.gender.{if $user->gender == 1}male{else}female{/if}{/lang}
{/if}
{if $user->isVisibleOption('birthday') && $user->getAge()}- {@$user->getAge()}
{/if}
{if $user->isVisibleOption('location') && $user->location}- {lang}wcf.user.membersList.location{/lang}
{/if}
@@ -47,6 +47,29 @@
{if $user->getCurrentLocation()}{@$user->getCurrentLocation()}{/if}
{/if}
+ {hascontent}
+
+ {content}
+ {event name='statistics'}
+
+ {if MODULE_LIKE && $user->likesReceived}
+ - {if !$user->isProtected()}{lang}wcf.like.likesReceived{/lang}{else}{lang}wcf.like.likesReceived{/lang}{/if}
+ - {#$user->likesReceived}
+ {/if}
+
+ {if $user->activityPoints}
+ - {lang}wcf.user.activityPoint{/lang}
+ - {#$user->activityPoints}
+ {/if}
+
+ {if $user->profileHits}
+ - {lang}wcf.user.profileHits{/lang}
+ - getProfileAge() > 1} title="{lang}wcf.user.profileHits.hitsPerDay{/lang}"{/if}>{#$user->profileHits}
+ {/if}
+ {/content}
+
+ {/hascontent}
+
-{hascontent}
-
- {lang}wcf.user.stats{/lang}
-
-
- {content}
- {event name='statistics'}
-
- {if MODULE_LIKE && $user->likesReceived}
- - {if !$user->isProtected()}{lang}wcf.like.likesReceived{/lang}{else}{lang}wcf.like.likesReceived{/lang}{/if}
- - {#$user->likesReceived}
- {/if}
-
- {if $user->activityPoints}
- - {lang}wcf.user.activityPoint{/lang}
- - {#$user->activityPoints}
- {/if}
-
- {if $user->profileHits}
- - {lang}wcf.user.profileHits{/lang}
- - getProfileAge() > 1} title="{lang}wcf.user.profileHits.hitsPerDay{/lang}"{/if}>{#$user->profileHits}
- {/if}
- {/content}
-
-
-{/hascontent}
-
-{event name='afterStatistics'}
-
{if !$user->isProtected()}
{if $followingCount}
diff --git a/wcfsetup/install/files/js/WCF.Comment.js b/wcfsetup/install/files/js/WCF.Comment.js
index c9cd72fa1d..6831fd8787 100644
--- a/wcfsetup/install/files/js/WCF.Comment.js
+++ b/wcfsetup/install/files/js/WCF.Comment.js
@@ -283,12 +283,12 @@ WCF.Comment.Handler = Class.extend({
if (comment.data('canEdit')) {
var $editButton = $(' ' + WCF.Language.get('wcf.global.button.edit') + '');
- $editButton.data('commentID', commentID).appendTo(comment.find('ul.commentOptions:eq(0)')).click($.proxy(this._prepareEdit, this));
+ $editButton.data('commentID', commentID).appendTo(comment.find('ul.buttonList:eq(0)')).click($.proxy(this._prepareEdit, this));
}
if (comment.data('canDelete')) {
var $deleteButton = $(' ' + WCF.Language.get('wcf.global.button.delete') + '');
- $deleteButton.data('commentID', commentID).appendTo(comment.find('ul.commentOptions:eq(0)')).click($.proxy(this._delete, this));
+ $deleteButton.data('commentID', commentID).appendTo(comment.find('ul.buttonList:eq(0)')).click($.proxy(this._delete, this));
}
},
@@ -317,14 +317,14 @@ WCF.Comment.Handler = Class.extend({
var $editButton = $(' ' + WCF.Language.get('wcf.global.button.edit') + '');
var self = this;
- $editButton.data('responseID', responseID).appendTo(response.find('ul.commentOptions:eq(0)')).click(function(event) { self._prepareEdit(event, true); });
+ $editButton.data('responseID', responseID).appendTo(response.find('ul.buttonList:eq(0)')).click(function(event) { self._prepareEdit(event, true); });
}
if (response.data('canDelete')) {
var $deleteButton = $(' ' + WCF.Language.get('wcf.global.button.delete') + '');
var self = this;
- $deleteButton.data('responseID', responseID).appendTo(response.find('ul.commentOptions:eq(0)')).click(function(event) { self._delete(event, true); });
+ $deleteButton.data('responseID', responseID).appendTo(response.find('ul.buttonList:eq(0)')).click(function(event) { self._delete(event, true); });
}
},
@@ -917,8 +917,8 @@ WCF.Comment.Like = WCF.Like.extend({
this._containers[containerID].find('.containerHeadline:eq(0) > h3').append(badge);
if (this._canLike) {
- likeButton.appendTo(this._containers[containerID].find('.commentOptions:eq(0)'));
- dislikeButton.appendTo(this._containers[containerID].find('.commentOptions:eq(0)'));
+ likeButton.appendTo(this._containers[containerID].find('ul.buttonList:eq(0)'));
+ dislikeButton.appendTo(this._containers[containerID].find('ul.buttonList:eq(0)'));
}
},
@@ -956,8 +956,8 @@ WCF.Comment.Response.Like = WCF.Like.extend({
this._containers[containerID].find('.containerHeadline:eq(0) > h3').append(badge);
if (this._canLike) {
- likeButton.appendTo(this._containers[containerID].find('.commentOptions:eq(0)'));
- dislikeButton.appendTo(this._containers[containerID].find('.commentOptions:eq(0)'));
+ likeButton.appendTo(this._containers[containerID].find('ul.buttonList:eq(0)'));
+ dislikeButton.appendTo(this._containers[containerID].find('ul.buttonList:eq(0)'));
}
},
diff --git a/wcfsetup/install/files/lib/page/UserPage.class.php b/wcfsetup/install/files/lib/page/UserPage.class.php
index 0915ea20de..5778cd2f06 100644
--- a/wcfsetup/install/files/lib/page/UserPage.class.php
+++ b/wcfsetup/install/files/lib/page/UserPage.class.php
@@ -130,20 +130,20 @@ class UserPage extends AbstractPage {
// get followers
$this->followerList = new UserFollowerList();
$this->followerList->getConditionBuilder()->add('user_follow.followUserID = ?', array($this->userID));
- $this->followerList->sqlLimit = 8;
+ $this->followerList->sqlLimit = 12;
$this->followerList->readObjects();
// get following
$this->followingList = new UserFollowingList();
$this->followingList->getConditionBuilder()->add('user_follow.userID = ?', array($this->userID));
- $this->followingList->sqlLimit = 8;
+ $this->followingList->sqlLimit = 12;
$this->followingList->readObjects();
// get visitors
if (PROFILE_ENABLE_VISITORS) {
$this->visitorList = new UserProfileVisitorList();
$this->visitorList->getConditionBuilder()->add('user_profile_visitor.ownerID = ?', array($this->userID));
- $this->visitorList->sqlLimit = 8;
+ $this->visitorList->sqlLimit = 12;
$this->visitorList->readObjects();
}
diff --git a/wcfsetup/install/files/style/layout/containerList.scss b/wcfsetup/install/files/style/layout/containerList.scss
index c6b432fe71..2c2428a684 100644
--- a/wcfsetup/install/files/style/layout/containerList.scss
+++ b/wcfsetup/install/files/style/layout/containerList.scss
@@ -60,7 +60,8 @@
}
> a {
- padding: 6px;
+ display: inline-block;
+ padding: 4px 6px;
> .icon {
color: rgba(0, 0, 0, .5);
diff --git a/wcfsetup/install/files/style/layout/global.scss b/wcfsetup/install/files/style/layout/global.scss
index a59b4bdf3c..2983324464 100644
--- a/wcfsetup/install/files/style/layout/global.scss
+++ b/wcfsetup/install/files/style/layout/global.scss
@@ -26,7 +26,7 @@
/* boxes with an image */
@mixin box($imageSize, $margin: 0) {
- display: flex !important;
+ display: flex;
> :first-child:not(:last-child) {
flex: 0 0 auto;
--
2.20.1