From 635abf01918157e61dc9cfdfd70c40bd5957b6a3 Mon Sep 17 00:00:00 2001 From: Peng Tao Date: Wed, 7 Dec 2016 17:52:19 +0800 Subject: [PATCH] vhost: remove unnecessary smp_mb from vhost_work_queue test_and_set_bit() already implies a memory barrier. Signed-off-by: Peng Tao Reviewed-by: Stefan Hajnoczi Signed-off-by: David S. Miller --- drivers/vhost/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index c6f2d89c0e97..266354390c8f 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -261,8 +261,8 @@ void vhost_work_queue(struct vhost_dev *dev, struct vhost_work *work) if (!test_and_set_bit(VHOST_WORK_QUEUED, &work->flags)) { /* We can only add the work to the list after we're * sure it was not in the list. + * test_and_set_bit() implies a memory barrier. */ - smp_mb(); llist_add(&work->node, &dev->work_list); wake_up_process(dev->worker); } -- 2.20.1