From 61074d394f77f8123a3f676a1d804c30e04df7e3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim=20D=C3=BCsterhus?= Date: Wed, 3 Feb 2021 11:03:20 +0100 Subject: [PATCH] Add explicit parentheses around mixed boolean operators in BooleanUserGroupOptionType see #3926 --- .../option/user/group/BooleanUserGroupOptionType.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wcfsetup/install/files/lib/system/option/user/group/BooleanUserGroupOptionType.class.php b/wcfsetup/install/files/lib/system/option/user/group/BooleanUserGroupOptionType.class.php index e521d598a2..eb9d5e5445 100644 --- a/wcfsetup/install/files/lib/system/option/user/group/BooleanUserGroupOptionType.class.php +++ b/wcfsetup/install/files/lib/system/option/user/group/BooleanUserGroupOptionType.class.php @@ -57,7 +57,7 @@ class BooleanUserGroupOptionType extends BooleanOptionType implements IUserGroup } // don't save if values are equal or $defaultValue is better - if ($defaultValue == $groupValue || $defaultValue && !$groupValue) { + if ($defaultValue == $groupValue || ($defaultValue && !$groupValue)) { return; } -- 2.20.1