From 57faf1e980fd6f14d4e51aa536d2d0c16835ed7e Mon Sep 17 00:00:00 2001 From: Alexander Ebert Date: Fri, 25 Jun 2021 16:27:40 +0200 Subject: [PATCH] Incorrect access of an element that is not always present --- ts/WoltLabSuite/Core/Ui/Message/Quote.ts | 4 ++-- .../install/files/js/WoltLabSuite/Core/Ui/Message/Quote.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ts/WoltLabSuite/Core/Ui/Message/Quote.ts b/ts/WoltLabSuite/Core/Ui/Message/Quote.ts index c60e5fc0d9..551fd9b3f1 100644 --- a/ts/WoltLabSuite/Core/Ui/Message/Quote.ts +++ b/ts/WoltLabSuite/Core/Ui/Message/Quote.ts @@ -483,8 +483,8 @@ export class UiMessageQuote implements AjaxCallbackObject { } // close navigation on mobile - const navigationList = listItem.closest(".buttonGroupNavigation") as HTMLUListElement; - if (navigationList.classList.contains("jsMobileButtonGroupNavigation")) { + const navigationList = listItem.closest(".buttonGroupNavigation") as HTMLUListElement | null; + if (navigationList && navigationList.classList.contains("jsMobileButtonGroupNavigation")) { const dropDownLabel = navigationList.querySelector(".dropdownLabel") as HTMLElement; dropDownLabel.click(); } diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Message/Quote.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Message/Quote.js index 917194b599..c3daffa6b4 100644 --- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Message/Quote.js +++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Message/Quote.js @@ -358,7 +358,7 @@ define(["require", "exports", "tslib", "../../Ajax", "../../Core", "../../Event/ } // close navigation on mobile const navigationList = listItem.closest(".buttonGroupNavigation"); - if (navigationList.classList.contains("jsMobileButtonGroupNavigation")) { + if (navigationList && navigationList.classList.contains("jsMobileButtonGroupNavigation")) { const dropDownLabel = navigationList.querySelector(".dropdownLabel"); dropDownLabel.click(); } -- 2.20.1