From 55c95e738da85373965cb03b4f975d0fd559865b Mon Sep 17 00:00:00 2001 From: Rami Rosen Date: Thu, 3 Jun 2010 05:02:29 +0000 Subject: [PATCH] fix return value of __pppoe_xmit() method. Hi, __pppoe_xmit() in drivers/net/pppoe always returns 1. When the methods fails (via goto abort), it should return 0 and not 1. Regards, Rami Rosen Signed-off-by: Rami Rosen Signed-off-by: David S. Miller --- drivers/net/pppoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index 805b64d1e893..7ebb8e87efa4 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb) abort: kfree_skb(skb); - return 1; + return 0; } /************************************************************************ -- 2.20.1