From 545a697512a0b9c08ae4f152b7dd146f02dcbb92 Mon Sep 17 00:00:00 2001 From: Alex Elder Date: Wed, 5 Nov 2014 16:03:11 -0600 Subject: [PATCH] greybus: control printing message There's a message that gets printed in gb_manifest_parse() if excess descriptors are found in the manifest. This should only be printed if the parse was successful. If it was not successful it's not really very helpful. Signed-off-by: Alex Elder Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/manifest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/manifest.c b/drivers/staging/greybus/manifest.c index 2e22f545e15b..563463955cb0 100644 --- a/drivers/staging/greybus/manifest.c +++ b/drivers/staging/greybus/manifest.c @@ -391,7 +391,7 @@ bool gb_manifest_parse(struct gb_module *gmod, void *data, size_t size) * We really should have no remaining descriptors, but we * don't know what newer format manifests might leave. */ - if (!list_empty(&manifest_descs)) + if (result && !list_empty(&manifest_descs)) pr_info("excess descriptors in module manifest\n"); out: release_manifest_descriptors(); -- 2.20.1