From 4b997e0c8cad0bae608158dfca662660bf94cd5c Mon Sep 17 00:00:00 2001
From: Alexander Ebert <ebert@woltlab.com>
Date: Tue, 1 Sep 2020 16:44:53 +0200
Subject: [PATCH] Report any duplicate usernames before applying the upgrade

Fixes #3544
---
 com.woltlab.wcf/files_pre.tar                 | Bin 4910080 -> 4912128 bytes
 com.woltlab.wcf/package.xml                   |   3 ++
 .../update_com.woltlab.wcf_5.3_preUpdate.php  |  31 ++++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 wcfsetup/install/files/acp/update_com.woltlab.wcf_5.3_preUpdate.php

diff --git a/com.woltlab.wcf/files_pre.tar b/com.woltlab.wcf/files_pre.tar
index 7d79221d99332885d3a9472db18efb9bf5ca0ea7..5835c63a372f0647dcf1f1bb607fa0224634461a 100644
GIT binary patch
delta 1158
zcmZ8fO>Y}j6pc%P%<vf+C=}Y>x+%7Uo!CxVLxSBVu9MW51T_s6q9_{AT#rZfjHfei
z)T9WxizBgQQ3>x53&e(1H;sh40A<M^U{#RVAoi@`j-ycmqxsOhd+vGXo_Fs5`oppN
zf69Xtj^QaB$J2NQ&te=JbUcUW@d94NOL!R*cm*dgiC6I&PU3aEfm3)BZ{ak~;4BE|
zkj8mT;R4=923h1Vjdzeo0W+9I5hau{hk0DYB~<V(-opYG@jj}k;WDmZ3CpPCDjHb9
zD%NoAyXIeCKWUyB-}VFE@-1UXKQ(JZ>q+zMsdBMY87s|I%5(D<FI7s#v0||_Uny3`
zio*#lW$mSYYaUNc>Ym|p=o==}U9)q`F#SdS!Os&X2D&~wJ+0F;)w^uo4yn@*$nbW_
ziu|5q8j2|jIT&@zx<y92AE=O2R|>uz7#5S$8Fd%|OLyd1GcjHKTrncm6~586)Z-l?
z;D8!!4%Db__KW^*;MiRykg^Cbl#Ase-R$>N%V^W8+g=;tL<xH#$2<?d`S$$qmp_`N
z!Kfk=-8Sq|C28A?9L2Zl{eT5AtLszYogP&wz1e6r>NiGOMz3V9Jk>Y0)^B8!|D3L^
zT;KTc5J<6QX_}#%^_A^)`KGr8I|y`b_4>xvN3{G&f=wuNZEfk}YwN4YI{kkOs?p{2
zqDWKXu*;qjfx^D9V6(cqoXr(#a?rjwx|sm7@ff)yEdy1k@eZ4j;_RoT&*D<DeJE^)
z)P-7ymDz1Mp~_|wNJj9w99;GsyT01Z9`@#P^trCZr9@E6@a#xTj%A6y6=#R7mN7V3
ztoJP`P_<g6jK!Hzvo<AJ3*%!E+Z&EYf(gjwZa~ZIMe5!`pgam4NmRVvG0ZO6Y;&8v
zJXsFQVSmu~6no_EKMq6r-it!R6{~FS>_6@XYH+}6b8r7qXi9?aa$vEyKo>%BR{KKN
zxF;+!%YWo-cuW#WSK@Ib*}Nm}kQ?=s<M)`9BLn2)kPCxhnv!bCyc-Fo%_2Ck**Y21
zSlna9){#y1;luAMr-%RiogJS_Y{--2`n}kwOrGREYWCipAM0PG_GohH_tcQI)R+GP
DQ4n<I

delta 169
zcmWN=Nj8E3007|kXGo?L(xf68nn*~dP)Mg}=@>1(JJ?#-bpTiC2)#~`@4as{9fwAf
z{{kTk7A;v8wjyHHnspmCMQw?R+qPp@!k(m*w2Z8MIe7&K4iz0KId<aInX-zin!0lr
s8ZI?mxpt%FR@<F>4<0?~c=qB|SI?VwANoFj2eZH7SNtdVE<}Ri9J9qa_W%F@

diff --git a/com.woltlab.wcf/package.xml b/com.woltlab.wcf/package.xml
index f3ea210b97..c0b97fd4ad 100644
--- a/com.woltlab.wcf/package.xml
+++ b/com.woltlab.wcf/package.xml
@@ -55,6 +55,9 @@
 		     Guzzle can not be found during the development of the regular file PIP. -->
 		<instruction type="file" run="standalone">files_pre.tar</instruction>
 		
+		<!-- Verify that there are no duplicate usernames and warn about them if any are found. -->
+		<instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.3_preUpdate.php</instruction>
+		
 		<!-- Deploy the database changes as early as possible to avoid any conflicts by calls to
 		     tables that do not exist in 5.2, in particular `wcfN_devtools_missing_language_item`.-->
 		<instruction type="script" run="standalone">acp/update_com.woltlab.wcf_5.3.php</instruction>
diff --git a/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.3_preUpdate.php b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.3_preUpdate.php
new file mode 100644
index 0000000000..bbcb970fc6
--- /dev/null
+++ b/wcfsetup/install/files/acp/update_com.woltlab.wcf_5.3_preUpdate.php
@@ -0,0 +1,31 @@
+<?php
+namespace wcf\acp;
+use wcf\system\WCF;
+
+/**
+ * Checks for any duplicate usernames and aborts the upgrade if any are found.
+ * 
+ * @author      Alexander Ebert
+ * @copyright   2001-2020 WoltLab GmbH
+ * @license     GNU Lesser General Public License <http://opensource.org/licenses/lgpl-license.php>
+ * @package     WoltLabSuite\Core
+ */
+
+$sql = "SELECT          username, COUNT(username)
+	FROM            wcf" . WCF_N . "_user
+	GROUP BY        username
+	HAVING          COUNT(username) > ?";
+$statement = WCF::getDB()->prepareStatement($sql);
+$statement->execute([1]);
+$usernames = $statement->fetchList('username');
+
+if (!empty($usernames)) {
+	if (WCF::getLanguage()->getFixedLanguageCode() === 'de') {
+		$message = "Ein oder mehr Benutzernamen sind mehrfach gegeben, diese Konten müssen zusammengeführt oder gelöscht werden: %s";
+	}
+	else {
+		$message = "One or more usernames exist multiple times, these accounts must be merged or deleted: %s";
+	}
+	
+	throw new \RuntimeException(sprintf($message, implode(', ', $usernames)));
+}
-- 
2.20.1