From 48f70474f48f87cc2dec5ee0a2ba7139bbef3cef Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Fri, 27 Mar 2015 11:38:06 +0100 Subject: [PATCH] greybus: debugfs: we shouldn't care if debugfs is working or not This removes the error checking for debugfs initialization as we really don't care if it failed or not. Signed-off-by: Greg Kroah-Hartman Reviewed-by: Alex Elder --- drivers/staging/greybus/core.c | 6 +----- drivers/staging/greybus/debugfs.c | 6 +----- drivers/staging/greybus/greybus.h | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c index a25df369d2b9..96265a1d668f 100644 --- a/drivers/staging/greybus/core.c +++ b/drivers/staging/greybus/core.c @@ -212,11 +212,7 @@ static int __init gb_init(void) BUILD_BUG_ON(HOST_DEV_CPORT_ID_MAX >= (long)CPORT_ID_BAD); - retval = gb_debugfs_init(); - if (retval) { - pr_err("debugfs failed\n"); - return retval; - } + gb_debugfs_init(); retval = bus_register(&greybus_bus_type); if (retval) { diff --git a/drivers/staging/greybus/debugfs.c b/drivers/staging/greybus/debugfs.c index b8865d707362..59c570964b01 100644 --- a/drivers/staging/greybus/debugfs.c +++ b/drivers/staging/greybus/debugfs.c @@ -15,13 +15,9 @@ static struct dentry *gb_debug_root; -int gb_debugfs_init(void) +void gb_debugfs_init(void) { gb_debug_root = debugfs_create_dir("greybus", NULL); - if (!gb_debug_root) - return -ENOENT; - - return 0; } void gb_debugfs_cleanup(void) diff --git a/drivers/staging/greybus/greybus.h b/drivers/staging/greybus/greybus.h index 967d64faa8fd..5a7f6227c1e5 100644 --- a/drivers/staging/greybus/greybus.h +++ b/drivers/staging/greybus/greybus.h @@ -158,7 +158,7 @@ int greybus_disabled(void); int greybus_svc_in(struct greybus_host_device *hd, u8 *data, int length); int gb_ap_init(void); void gb_ap_exit(void); -int gb_debugfs_init(void); +void gb_debugfs_init(void); void gb_debugfs_cleanup(void); struct dentry *gb_debugfs_get(void); -- 2.20.1