From 485f4912b67adffba80444aa10a5490fd9494cf1 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Fri, 27 May 2022 15:22:55 +0200
Subject: [PATCH] Remove RouteHandler::getDefaultController()

This method was unused and returned questionable data as the administrator is
free to configure a differing landing page / default controller.
---
 .../lib/system/request/RouteHandler.class.php | 54 -------------------
 1 file changed, 54 deletions(-)

diff --git a/wcfsetup/install/files/lib/system/request/RouteHandler.class.php b/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
index c84c417226..e309fdebd9 100644
--- a/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
+++ b/wcfsetup/install/files/lib/system/request/RouteHandler.class.php
@@ -2,14 +2,12 @@
 
 namespace wcf\system\request;
 
-use wcf\system\application\ApplicationHandler;
 use wcf\system\event\EventHandler;
 use wcf\system\exception\SystemException;
 use wcf\system\request\route\DynamicRequestRoute;
 use wcf\system\request\route\IRequestRoute;
 use wcf\system\request\route\LookupRequestRoute;
 use wcf\system\SingletonFactory;
-use wcf\system\WCF;
 use wcf\util\FileUtil;
 
 /**
@@ -55,12 +53,6 @@ class RouteHandler extends SingletonFactory
      */
     protected static $secure;
 
-    /**
-     * list of application abbreviation and default controller name
-     * @var string[]
-     */
-    protected $defaultControllers;
-
     /**
      * true if the default controller is used (support for custom landing page)
      * @var bool
@@ -388,50 +380,4 @@ class RouteHandler extends SingletonFactory
 
         return self::$pathInfo;
     }
-
-    /**
-     * Returns the default controller name for given application.
-     *
-     * @param string $application
-     * @return  string
-     */
-    public function getDefaultController($application)
-    {
-        $this->loadDefaultControllers();
-
-        if (isset($this->defaultControllers[$application])) {
-            return $this->defaultControllers[$application];
-        }
-
-        return '';
-    }
-
-    /**
-     * Loads the default controllers for each active application.
-     */
-    protected function loadDefaultControllers()
-    {
-        if ($this->defaultControllers === null) {
-            $this->defaultControllers = [];
-
-            foreach (ApplicationHandler::getInstance()->getApplications() as $application) {
-                $app = WCF::getApplicationObject($application);
-
-                if (!$app) {
-                    continue;
-                }
-
-                $controller = $app->getPrimaryController();
-
-                if (!$controller) {
-                    continue;
-                }
-
-                $controller = \explode('\\', $controller);
-                $controllerName = \preg_replace('~(Action|Form|Page)$~', '', \array_pop($controller));
-
-                $this->defaultControllers[$controller[0]] = $controllerName;
-            }
-        }
-    }
 }
-- 
2.20.1