From 3dca03de9db7c467811bdfcb0b3b90cb9a184a8f Mon Sep 17 00:00:00 2001 From: Viresh Kumar Date: Mon, 31 Aug 2015 17:21:10 +0530 Subject: [PATCH] greybus: connection: convert connected dev_warn() to dev_err() Failures from control-connected operations are fatal errors and must be reported with dev_err() instead of dev_warn(). Fix it. Reviewed-by: Johan Hovold Signed-off-by: Viresh Kumar [ johan: do not promote disconnected warnings, update summary ] Signed-off-by: Johan Hovold --- drivers/staging/greybus/connection.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index 62cbeb304616..f89b199230dc 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -386,9 +386,9 @@ static int gb_connection_init(struct gb_connection *connection) ret = gb_control_connected_operation(control, cport_id); if (ret) { - dev_warn(&connection->dev, - "Failed to connect CPort-%d (%d)\n", - cport_id, ret); + dev_err(&connection->dev, + "Failed to connect CPort-%d (%d)\n", + cport_id, ret); return 0; } } -- 2.20.1