From 3ccf8b2702fd937bcdee879d41f7326841a51b37 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Tim=20D=C3=BCsterhus?= <duesterhus@woltlab.com>
Date: Wed, 11 May 2022 12:58:23 +0200
Subject: [PATCH] Remove the use of WCF::getFavicon()

This method was required to correctly handle multi-domain setups and thus is
obsolete.
---
 com.woltlab.wcf/templates/headInclude.tpl       |  2 +-
 wcfsetup/install/files/lib/system/WCF.class.php | 14 +-------------
 2 files changed, 2 insertions(+), 14 deletions(-)

diff --git a/com.woltlab.wcf/templates/headInclude.tpl b/com.woltlab.wcf/templates/headInclude.tpl
index da2b9a2b88..a301055c50 100644
--- a/com.woltlab.wcf/templates/headInclude.tpl
+++ b/com.woltlab.wcf/templates/headInclude.tpl
@@ -26,7 +26,7 @@
 <!-- Icons -->
 <link rel="apple-touch-icon" sizes="180x180" href="{$__wcf->getStyleHandler()->getStyle()->getFaviconAppleTouchIcon()}">
 <link rel="manifest" href="{@$__wcf->getStyleHandler()->getStyle()->getFaviconManifest()}">
-<link rel="shortcut icon" href="{@$__wcf->getFavicon()}">
+<link rel="shortcut icon" href="{$__wcf->getPath()}{$__wcf->getStyleHandler()->getStyle()->getRelativeFavicon()}">
 <meta name="msapplication-config" content="{@$__wcf->getStyleHandler()->getStyle()->getFaviconBrowserconfig()}">
 <meta name="theme-color" content="{$__wcf->getStyleHandler()->getStyle()->getVariable('wcfPageThemeColor', true)}">
 
diff --git a/wcfsetup/install/files/lib/system/WCF.class.php b/wcfsetup/install/files/lib/system/WCF.class.php
index 924f3c92e4..f52b9dcc66 100644
--- a/wcfsetup/install/files/lib/system/WCF.class.php
+++ b/wcfsetup/install/files/lib/system/WCF.class.php
@@ -1153,24 +1153,12 @@ class WCF
     }
 
     /**
-     * Returns the favicon URL or a base64 encoded image.
-     *
-     * @return  string
+     * @deprecated 5.6 Use ActiveStyle::getRelativeFavicon() directly.
      */
     public function getFavicon()
     {
-        $activeApplication = ApplicationHandler::getInstance()->getActiveApplication();
-        $wcf = ApplicationHandler::getInstance()->getWCF();
         $favicon = StyleHandler::getInstance()->getStyle()->getRelativeFavicon();
 
-        if ($activeApplication->domainName !== $wcf->domainName) {
-            if (\file_exists(WCF_DIR . $favicon)) {
-                $favicon = \file_get_contents(WCF_DIR . $favicon);
-
-                return 'data:image/x-icon;base64,' . \base64_encode($favicon);
-            }
-        }
-
         return self::getPath() . $favicon;
     }
 
-- 
2.20.1